Closed
Bug 1034611
Opened 10 years ago
Closed 8 years ago
Make worker JS runtime creation fallible
Categories
(Core :: DOM: Workers, defect)
Core
DOM: Workers
Tracking
()
RESOLVED
DUPLICATE
of bug 1247122
People
(Reporter: mccr8, Unassigned)
References
Details
Attachments
(1 file)
5.32 KB,
patch
|
Details | Diff | Splinter Review |
With GGC, workers apparently need a 16MB nursery, which is created when we create the JSRuntime. That's huge, so we should make it fallible. Fortunately, this only requires some minor code shuffling. (We may separately want to consider reducing the nursery size for workers.)
That's crazy. We absolutely cannot have a 16 MB nursery for workers.
Reporter | ||
Comment 2•10 years ago
|
||
This compiles and passes worker tests, though I'm getting one failure locally: TEST-UNEXPECTED-FAIL | /tests/dom/workers/test/test_multi_sharedWorker_lifetimes.html | Still have data stored - got undefined, expected 0123456789abcdefghijklmnopqrstuvwxyz
Attachment #8450985 -
Flags: feedback?(khuey)
Comment 3•10 years ago
|
||
That's bug 995688, no? Of course, bonus points if you can fix that while you're at it ;)
Reporter | ||
Comment 4•10 years ago
|
||
Hmm, yeah, looks like I commented back in April that it is permaorange for me. ;)
We know that we fail this allocation at least on tinderboxes so we'll need to do something more sophisticated than just bailing out of WorkerThreadPrimaryRunnable::Run I think.
Reporter | ||
Comment 6•10 years ago
|
||
I was hoping that returning an error would somehow magically turn into an exception in the parent thread. Is that the sort of behavior you'd expect, Ben?
No, sadly :(
Reporter | ||
Comment 8•10 years ago
|
||
By the last sentence, I meant what is the desired behavior here? :)
Comment on attachment 8450985 [details] [diff] [review] Make worker JS runtime allocation fallible. So we established that this approach doesn't work, right?
Attachment #8450985 -
Flags: feedback?(khuey)
Reporter | ||
Comment 10•10 years ago
|
||
I haven't checked yet, but I'm assuming it doesn't. Sorry, I should have cleared the feedback flag after bent commented.
Reporter | ||
Updated•9 years ago
|
Assignee: continuation → nobody
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•