Closed Bug 1034632 Opened 7 years ago Closed 7 years ago

MOZILLA_PKIX_ENUM_CLASS disables warning 4480 for the whole file instead of just for the one enum

Categories

(Core :: Security: PSM, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: briansmith, Assigned: briansmith)

Details

Attachments

(1 file)

I meant to use __pragma(warning(suppress)), but I used __pragma(warning(disable)) instead.

See the documentation about suppress at http://msdn.microsoft.com/en-us/library/2c8f766e.aspx: "Pushes the current state of the pragma on the stack, disables the specified warning for the next line, and then pops the warning stack so that the pragma state is reset."
Assignee: nobody → brian
Status: NEW → ASSIGNED
Attachment #8451008 - Flags: review?(mmc)
Comment on attachment 8451008 [details] [diff] [review]
fix-MOZILLA_PKIX_ENUM_CLASS-pragma.patch

Review of attachment 8451008 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM pending green try (since fail on warnings is enabled for this module, right?)
Attachment #8451008 - Flags: review?(mmc) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/740e7042cd97

(In reply to [:mmc] Monica Chew (please use needinfo) from comment #2)
> LGTM pending green try (since fail on warnings is enabled for this module,
> right?)

Yes, fail-on-warnings is enabled for security/pkix and security/certverifier. I ran this through try last night before I asked for review, like a good boy.

Thanks for the fast review!
Target Milestone: --- → mozilla33
https://hg.mozilla.org/mozilla-central/rev/740e7042cd97
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.