1034634 - Fix compiler warnings in ScopedNSSTypes.h

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: ScopedNSSTypes-without-warnings.patch

Comment 1

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 8451012 [details] [diff] [review]
ScopedNSSTypes-without-warnings.patch

Review of attachment 8451012 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/manager/ssl/src/ScopedNSSTypes.h
@@ +173,5 @@
>    }
>  
>    nsresult DigestBuf(SECOidTag hashAlg, const uint8_t * buf, uint32_t len)
>    {
> +    if (len > static_cast<uint32_t>(std::numeric_limits<int32_t>::max())) {

Seems odd to check uint32_t against max of a different type, but I guess this is because HashBuf takes the wrong type.

@@ +204,2 @@
>      {
>        case SEC_OID_SHA1:   item.len = SHA1_LENGTH;   break;

This style seems prone to goto-fail bugs. All it takes is one missing break.

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to [:mmc] Monica Chew (please use needinfo) from comment #1)
> ::: security/manager/ssl/src/ScopedNSSTypes.h
> @@ +173,5 @@
> >    }
> >  
> >    nsresult DigestBuf(SECOidTag hashAlg, const uint8_t * buf, uint32_t len)
> >    {
> > +    if (len > static_cast<uint32_t>(std::numeric_limits<int32_t>::max())) {
> 
> Seems odd to check uint32_t against max of a different type, but I guess
> this is because HashBuf takes the wrong type.

Right. And, I remember that the NSS team didn't want to change it, because it might break source compatibility. :(

> @@ +204,2 @@
> >      {
> >        case SEC_OID_SHA1:   item.len = SHA1_LENGTH;   break;
> 
> This style seems prone to goto-fail bugs. All it takes is one missing break.

This style was chosen to make a missing break more obvious. Basically C/C++ switch statements suck.

Thanks for the review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/5bd954b643e9

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/5bd954b643e9