Closed Bug 1034637 Opened 5 years ago Closed 5 years ago

[Messages] Utils.js unit tests are failing when run locally

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, minor)

ARM
Gonk (Firefox OS)
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: azasypkin, Assigned: azasypkin)

References

Details

(Whiteboard: [not-part-of-initial-sprint])

Attachments

(1 file)

Once patch for bug 974867 has been landed some test suites inside utils_test.js started to depend on MockSettings that is not properly set up for these suites.
Comment on attachment 8451025 [details] [review]
GitHub pull request URL

Hey Julien,

Here is tiny patch that adds mocks initialization to the utils test suites that require it. 

Also it seems I found a reason why these tests are passing locally with newer version of FF - something has changed in Gecko recently so that 'navigator.mozPhoneNumberService' is no longer accessible and FixturePhones object isn't initialized that lead to partial execution of utils_test.js tests (when test env analyzes what suites to run in this file, it encounters error in 'Varied Cases' suite and all next suites are just skipped). I'm not sure why this situation isn't reported by test env as failure.

I've fixed that too.
Attachment #8451025 - Flags: review?(felash)
Comment on attachment 8451025 [details] [review]
GitHub pull request URL

r=me
thanks
Attachment #8451025 - Flags: review?(felash) → review+
Master: https://github.com/mozilla-b2g/gaia/commit/6ee4efa67fbf710211816b3bb8801f03d6e792d8
Blocks: sms-sprint-4
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [not-part-of-initial-sprint]
You need to log in before you can comment on or make changes to this bug.