Closed Bug 1034665 Opened 5 years ago Closed 5 years ago

IonMonkey: Implement RAtan2 Recover Instruction

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: tandiap, Assigned: tandiap, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

No description provided.
Implement RAtan2 in js/src/jit/Recover.cpp
See Bug 1003801 comment 0 for explanation.
Blocks: 1003801
Hardware: x86_64 → All
I would like to work on this bug.
Attached patch 1034665.patch (obsolete) — Splinter Review
Attached patch 1034665.patch (obsolete) — Splinter Review
Attachment #8451273 - Attachment is obsolete: true
Attached patch 1034665.patch (obsolete) — Splinter Review
Attachment #8451274 - Attachment is obsolete: true
Attachment #8451276 - Flags: review?(nicolas.b.pierron)
Assignee: nobody → patandia
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 8451276 [details] [diff] [review]
1034665.patch

Review of attachment 8451276 [details] [diff] [review]:
-----------------------------------------------------------------

Nice :)

Request a Level 1 access [1], and send your patch to the try server [2].
For JS modification, such as recover instructions, I use:
  try: -b do -p linux,linux64,linux64-asan,linux64-st-an,linux64-valgrind -u jsreftest,jittests,jittest-1,jittest-2 -t none
 
The if the try-push is green, then you can set the checkin-needed keyword to request a sheriff to land it for you ;)

We use Try pushes verify on platform on which we cannot test, and which might be enough to highlight most of the issue.

[1] http://www.mozilla.org/hacking/commit-access-policy/
[2] http://trychooser.pub.build.mozilla.org/
Attachment #8451276 - Flags: review?(nicolas.b.pierron) → review+
Attached patch 1034665.patchSplinter Review
Patch update (source merge).
Attachment #8451276 - Attachment is obsolete: true
Comment on attachment 8456666 [details] [diff] [review]
1034665.patch

https://tbpl.mozilla.org/?tree=Try&rev=a398b8212361
Attachment #8456666 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8456666 [details] [diff] [review]
1034665.patch

Review of attachment 8456666 [details] [diff] [review]:
-----------------------------------------------------------------

No need to ask again for review when there is no logical change in the patch.
Attachment #8456666 - Flags: review?(nicolas.b.pierron) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/de68b3204351
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.