1034907 - Remove dangerous public destructor of dom::TimeRanges

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

In bug 1028588 we removed dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.

One of them is: dom::TimeRanges

Comment 1

[Michael Pruett]

Attachment: Patch

I've removed the public destructor of TimeRanges and updated affected uses accordingly.

Here are the results from the try server:

https://tbpl.mozilla.org/?tree=Try&rev=d816e20e068b

Comment 2

[Andrew McCreight [:mccr8]]

Comment on attachment 8454962 [details] [diff] [review]
Patch

Review of attachment 8454962 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.  I'm going to forward the review to a DOM peer.

Comment 3

[Andrew McCreight [:mccr8]]

For a little change like this, it probably would have been enough to do a Linux64 debug-only try run.

Comment 4

[Olli Pettay [:smaug]]

Comment on attachment 8454962 [details] [diff] [review]
Patch


>   // Clamp the seek target to inside the seekable ranges.
>-  dom::TimeRanges seekable;
>-  if (NS_FAILED(mDecoder->GetSeekable(&seekable))) {
>+  nsRefPtr<dom::TimeRanges> seekable = new dom::TimeRanges();
>+  if (NS_FAILED(mDecoder->GetSeekable(seekable))) {

Uhhuh. Thank you for fixing this crazyness.

Comment 5

[Andrew McCreight [:mccr8]]

Thanks for the patch!

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/877406ac6f1d

Comment 7

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/877406ac6f1d