Closed Bug 1034916 Opened 8 years ago Closed 8 years ago

Remove dangerous public destructor of nsUTF8ConverterService

Categories

(Core :: Internationalization, defect)

Other Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: bjacob, Assigned: mccr8)

References

Details

Attachments

(1 file)

In bug 1028588 we removed dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.

One of them is: nsUTF8ConverterService
Assignee: nobody → continuation
Attachment #8464349 - Flags: review?(ehsan) → review+
I added an include to nsCookie.cpp and verified it builds in non-unified builds locally.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e48378aaf726
https://hg.mozilla.org/mozilla-central/rev/e48378aaf726
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.