1034916 - Remove dangerous public destructor of nsUTF8ConverterService

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

In bug 1028588 we removed dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.

One of them is: nsUTF8ConverterService

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Remove dangerous public destructor of nsUTF8ConverterService.

try: https://tbpl.mozilla.org/?tree=Try&rev=daa327c18c40

Comment 2

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a1fb4230b8b8

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Backed out for non-unified bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f887288d0468

https://tbpl.mozilla.org/php/getParsedLog.php?id=44919068&tree=Mozilla-Inbound

Comment 4

[Andrew McCreight [:mccr8]]

I added an include to nsCookie.cpp and verified it builds in non-unified builds locally.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e48378aaf726

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e48378aaf726