1034918 - Remove dangerous public destructor of nsHttpTransaction

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

In bug 1028588 we removed dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.

One of them is: nsHttpTransaction

Comment 1

[Patrick McManus [:mcmanus]]

https://tbpl.mozilla.org/?tree=Try&rev=6664575eaae9

Comment 2

[Patrick McManus [:mcmanus]]

Attachment: nshttptransaction dtor can be private

Comment 3

[Steve Workman [:sworkman] (INACTIVE)]

Comment on attachment 8451652 [details] [diff] [review]
nshttptransaction dtor can be private

Review of attachment 8451652 [details] [diff] [review]:
-----------------------------------------------------------------

One question, otherwise r=me.

::: netwerk/protocol/http/nsHttpTransaction.h
@@ +63,5 @@
>      NS_DECL_NSIINPUTSTREAMCALLBACK
>      NS_DECL_NSIOUTPUTSTREAMCALLBACK
>  
>      nsHttpTransaction();
> +public:

Do you need this?

Comment 4

[Patrick McManus [:mcmanus]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b97cd8239c53

Comment 5

[Patrick McManus [:mcmanus]]

backed out remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d76669861f43

Comment 6

[Patrick McManus [:mcmanus]]

1028588 landed an assert change after the try run that broke this. needs a minor tweak to remove the whitelist.

/builds/slave/m-in-osx64_g-00000000000000000/build/netwerk/protocol/http/nsHttpTransaction.cpp:1812:1: error: static_assert failed "Class nsHttpTransaction has no public destructor. That's good! So please remove the HasDangerousPublicDestructor specialization for it."
NS_IMPL_ADDREF(nsHttpTransaction)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../dist/include/nsISupportsImpl.h:559:3: note: expanded from macro 'NS_IMPL_ADDREF'
  MOZ_ASSERT_TYPE_OK_FOR_REFCOUNTING(_class)                                  \
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../dist/include/nsISupportsImpl.h:97:3: note: expanded from macro 'MOZ_ASSERT_TYPE_OK_FOR_REFCOUNTING'
  static_assert(!mozilla::HasDangerousPublicDestructor<X>::value || \
  ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

Sorry about the inconvenience!

Comment 8

[Patrick McManus [:mcmanus]]

pushed again with the portion of 1028588 that added the assert specifically about this code backed out

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/ea72e2c9debe

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ea72e2c9debe