1034925 - submit_balrog_updates ignores fatal_exit_code arg and does not change build status

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect)

Description

[Jordan Lund (:jlund)]

Attachment: 140705_balrog_ignores_fatal_exit_code.patch

this is part of a bigger issue. As it stands, if you run run_command() with halt_on_failure = False and fatal_exit_code = 3, the fatal_exit_code does nothing. This is because you chose to not fatal (halt_on_failure) so the fatal_exit_code arg is ignored.

bug 985068 will fix this so by me not getting to that yet, some of the responsibility falls on me here.

Regardless here is a quick fix for the balrog issue.

Comment 1

[Jordan Lund (:jlund)]

Attachment: 140706_balrog_ignores_fatal_exit_code.patch

this patch removes redundant log output of what the return code was.

also, turning the patch over to ben since he is back this week.

Comment 2

[[e-mail] (:bhearsum)]

I'm not sure we want to do this, per bug 922626. Ryan, do you still feel the same about this?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Not a ton of context to go off here, but based on my fuzzy recollections of bug 922626, Ben is right. In general, we don't want builds burning on TBPL for a non-fatal error. I might be persuaded to have them turn orange, though. In principle, I agree that silently missing errors is less than ideal :)

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 8451388 [details] [diff] [review]
140706_balrog_ignores_fatal_exit_code.patch

I'm going to take Ryan's comment as "orange is okay". So r=me if you set whatever rc turns into orange.

Comment 5

[Jordan Lund (:jlund)]

Attachment: 140717_balrog_ignores_fatal_exit_code.patch

r=bhearsum

Comment 6

[Jordan Lund (:jlund)]

Comment on attachment 8458396 [details] [diff] [review]
140717_balrog_ignores_fatal_exit_code.patch

https://hg.mozilla.org/build/mozharness/rev/2e66da12da92

Comment 7

[Aki Sasaki (not active)]

In production.

Comment 8

[[e-mail] (:bhearsum)]

This is buildbot, buildbot is dying!