1034930 - Improve the const correctness of BinaryOutputStream::writeBytes

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[(no longer active)]

This fixes a compilation problem with clang-cl.  The patch has been submitted to upstream:

https://chromium-review.googlesource.com/#/c/206714/

Comment 1

[(no longer active)]

Attachment: Improve the const correctness of BinaryOutputStream::writeBytes

Comment 2

[(no longer active)]

https://github.com/mozilla/angle/pull/5

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I'm holding off on reviewing this until I can get it into either mozilla/angle github or upstream.  I really don't want to patch things in gfx/angle in m-c unless absolutely necessary (e.g. security fix), because those are the patches that will instantly get lost...

Comment 4

[(no longer active)]

(In reply to comment #3)
> I'm holding off on reviewing this until I can get it into either mozilla/angle
> github or upstream.  I really don't want to patch things in gfx/angle in m-c
> unless absolutely necessary (e.g. security fix), because those are the patches
> that will instantly get lost...

Sure.  I've submitted it to both FWIW.  :-)

Comment 5

[(no longer active)]

This was finally merged upstream: <https://chromium.googlesource.com/angle/angle/+/aa7e166091b7aa779191ed6f60e4b1e51d029afd>.  Vlad, what do I need to do to get this landed on m-c?

Comment 7

[(no longer active)]

I'm going to land this for now.

Comment 8

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3fe58eba40c1

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3fe58eba40c1