Closed Bug 1034967 Opened 10 years ago Closed 10 years ago

Regression: Context menu broken over blank space in contact list

Categories

(Instantbird Graveyard :: Contacts window, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: nhnt11)

Details

Attachments

(1 file, 1 obsolete file)

STR
Disconnect all accounts and right-click on the contact list.

JavaScript error: chrome://instantbird/content/blist.js, line 83: this._getLogs(...) is null

The context menu entries shown are incorrect, and trying to "show offline contacts" produces:
JavaScript error: chrome://instantbird/content/blist.xul, line 1: gBuddyListContextMenu is null
Attached patch \ (obsolete) — Splinter Review
Comment on attachment 8451904 [details] [diff] [review]
\

Sorry, I think I pressed enter twice while attaching the file.
Attachment #8451904 - Attachment description: \ → Patch
Attachment #8451904 - Flags: review?(aleth)
Comment on attachment 8451904 [details] [diff] [review]
\

Review of attachment 8451904 [details] [diff] [review]:
-----------------------------------------------------------------

Funky patch name -- are you trying to hack bugzilla? Next time try something with DROP_TABLE ;)

r+ with nit fixed.

::: im/content/blist.js
@@ +70,5 @@
>    document.getElementById("context-show-conversation").hidden = !this.onConv && !uiConv;
>    document.getElementById("context-close-conversation-separator").hidden = !this.onConv;
>    document.getElementById("context-close-conversation").hidden = !this.onConv;
> +  let showLogsItem = document.getElementById("context-showlogs");
> +  let hideShowLogsItem =  hide && !this.onConv;

Nit: extra space
Attachment #8451904 - Attachment description: Patch → \
Attachment #8451904 - Flags: review+
Attachment #8451904 - Flags: review?(aleth)
Attached patch Patch 2Splinter Review
Fixed nit. Carrying forward the r+.
Attachment #8451904 - Attachment is obsolete: true
Attachment #8451910 - Flags: review+
https://hg.mozilla.org/comm-central/rev/c3b0ea24f4c3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.