1034967 - Regression: Context menu broken over blank space in contact list

Status: RESOLVED FIXED

(Instantbird Graveyard :: Contacts window, defect)

Description

[aleth [:aleth]]

STR
Disconnect all accounts and right-click on the contact list.

JavaScript error: chrome://instantbird/content/blist.js, line 83: this._getLogs(...) is null

The context menu entries shown are incorrect, and trying to "show offline contacts" produces:
JavaScript error: chrome://instantbird/content/blist.xul, line 1: gBuddyListContextMenu is null

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: \

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8451904 [details] [diff] [review]
\

Sorry, I think I pressed enter twice while attaching the file.

Comment 3

[aleth [:aleth]]

Comment on attachment 8451904 [details] [diff] [review]
\

Review of attachment 8451904 [details] [diff] [review]:
-----------------------------------------------------------------

Funky patch name -- are you trying to hack bugzilla? Next time try something with DROP_TABLE ;)

r+ with nit fixed.

::: im/content/blist.js
@@ +70,5 @@
>    document.getElementById("context-show-conversation").hidden = !this.onConv && !uiConv;
>    document.getElementById("context-close-conversation-separator").hidden = !this.onConv;
>    document.getElementById("context-close-conversation").hidden = !this.onConv;
> +  let showLogsItem = document.getElementById("context-showlogs");
> +  let hideShowLogsItem =  hide && !this.onConv;

Nit: extra space

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch 2

Fixed nit. Carrying forward the r+.

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

https://hg.mozilla.org/comm-central/rev/c3b0ea24f4c3