Closed
Bug 1034975
Opened 11 years ago
Closed 11 years ago
Crash in mozalloc_abort(char const* const) | NS_DebugBreak | nsDebugImpl::Abort(char const*, int) with AsyncShutdownTimer "Search service: shutting down"
Categories
(Firefox Health Report Graveyard :: Client: Desktop, defect)
Firefox Health Report Graveyard
Client: Desktop
Tracking
(firefox31 ?, firefox32 fixed, firefox33 fixed)
RESOLVED
FIXED
Firefox 33
People
(Reporter: u279076, Assigned: Yoric)
References
Details
(Keywords: crash)
Attachments
(1 file)
See also bug 944873 comment 51.
1. Load https://crash-stats.mozilla.com/report/list?signature=mozalloc_abort%28char%20const*%20const%29%20|%20NS_DebugBreak%20|%20nsDebugImpl%3A%3AAbort%28char%20const*%2C%20int%29#tab-reports
2. Click "Change columns in this table" or scroll to the bottom of the page
3. Select "AsyncShutdownTimeout" from the "Available columns" list
4. Click ">>" to add it to the list of "Chosen columns"
5. Click "Save and Reload"
6. Find in page "Search service: shutting down" and you'll see a lot of these crashes.
I don't know what the exact volume of this is as I don't know a good way to query crashstats on this AsyncShutdownTimer message. I only see one crash in the first page of the reports table though so this *may* be low volume.
Assignee | ||
Comment 1•11 years ago
|
||
Search Service is not registered as a client of OS.File shutdown although it depends on it. This is a possible cause of AsyncShutdown timeouts.
Fixing this and taking the opportunity to add more logging in case of crashes.
Assignee: nobody → dteller
Attachment #8451369 -
Flags: review?(gavin.sharp)
Attachment #8451369 -
Flags: review?(dtownsend+bugmail)
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 2•11 years ago
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8451369 [details] [diff] [review]
Making Shutdown of Search Service depend on OS.File.profileBeforeChange rather than AsyncShutdown.profileBeforeChange.
Review of attachment 8451369 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/search/nsSearchService.js
@@ +4198,5 @@
> + }
> +
> + // Ensure that error is reported and that it causes tests
> + // to fail.
> + Promise.reject(ex);
Don't you need to return this?
Attachment #8451369 -
Flags: review?(dtownsend+bugmail) → review+
Assignee | ||
Comment 4•11 years ago
|
||
In this case, I'm using uncaught Promise.rejects as a super Cu.reportError that also causes test failures, so, I do not want this promise to be caught.
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 5•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Updated•11 years ago
|
Attachment #8451369 -
Flags: review?(gavin.sharp)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 8451369 [details] [diff] [review]
Making Shutdown of Search Service depend on OS.File.profileBeforeChange rather than AsyncShutdown.profileBeforeChange.
Approval Request Comment
[Feature/regressing bug #]: Bug 940408
[User impact if declined]: Rare freeze/crashes during shutdown.
[Describe test coverage new/current, TBPL]: Just landed on mozilla-central. This probably deserves to cook a few days.
[Risks and why]: None that I can think of.
[String/UUID change made/needed]: None.
Attachment #8451369 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #8451369 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•11 years ago
|
Comment 8•11 years ago
|
||
Updated•7 years ago
|
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•