Closed Bug 1034975 Opened 6 years ago Closed 6 years ago
Crash in mozalloc
_abort(char const* const) | NS _Debug Break | ns Debug Impl::Abort(char const*, int) with Async Shutdown Timer "Search service: shutting down"
See also bug 944873 comment 51. 1. Load https://crash-stats.mozilla.com/report/list?signature=mozalloc_abort%28char%20const*%20const%29%20|%20NS_DebugBreak%20|%20nsDebugImpl%3A%3AAbort%28char%20const*%2C%20int%29#tab-reports 2. Click "Change columns in this table" or scroll to the bottom of the page 3. Select "AsyncShutdownTimeout" from the "Available columns" list 4. Click ">>" to add it to the list of "Chosen columns" 5. Click "Save and Reload" 6. Find in page "Search service: shutting down" and you'll see a lot of these crashes. I don't know what the exact volume of this is as I don't know a good way to query crashstats on this AsyncShutdownTimer message. I only see one crash in the first page of the reports table though so this *may* be low volume.
Search Service is not registered as a client of OS.File shutdown although it depends on it. This is a possible cause of AsyncShutdown timeouts. Fixing this and taking the opportunity to add more logging in case of crashes.
Comment on attachment 8451369 [details] [diff] [review] Making Shutdown of Search Service depend on OS.File.profileBeforeChange rather than AsyncShutdown.profileBeforeChange. Review of attachment 8451369 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/search/nsSearchService.js @@ +4198,5 @@ > + } > + > + // Ensure that error is reported and that it causes tests > + // to fail. > + Promise.reject(ex); Don't you need to return this?
Attachment #8451369 - Flags: review?(dtownsend+bugmail) → review+
In this case, I'm using uncaught Promise.rejects as a super Cu.reportError that also causes test failures, so, I do not want this promise to be caught.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Comment on attachment 8451369 [details] [diff] [review] Making Shutdown of Search Service depend on OS.File.profileBeforeChange rather than AsyncShutdown.profileBeforeChange. Approval Request Comment [Feature/regressing bug #]: Bug 940408 [User impact if declined]: Rare freeze/crashes during shutdown. [Describe test coverage new/current, TBPL]: Just landed on mozilla-central. This probably deserves to cook a few days. [Risks and why]: None that I can think of. [String/UUID change made/needed]: None.
Attachment #8451369 - Flags: approval-mozilla-aurora?
Attachment #8451369 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.