Closed
Bug 1034982
Opened 11 years ago
Closed 11 years ago
Add call progress protocol bits to the FxOS Loop client app (follow-up 1032380)
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaoo, Assigned: jaoo)
References
Details
Attachments
(1 file)
In bug 1032380 we added the call progress helper and played with the protocol in the test app (at [1]). Now it's time to add these bits to the final app.
[1] https://github.com/jaoo/firefoxos-loop-client/commits/call-progress-protocol
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → josea.olivera
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8451734 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/30
Borja, let's pair up for this review. Please, let me know when you are ready for it. Thanks.
Attachment #8451734 -
Flags: review?(borja.bugzilla)
|
||
Updated•11 years ago
|
Blocks: Loopmov_1_1
No longer depends on: Loopmov_1_1
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8451734 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/30
Small comments to address. Please fix them and merge it! :)
Attachment #8451734 -
Flags: review?(borja.bugzilla) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
(In reply to Borja Salguero (part-time in Gaia) [:borjasalguero] from comment #3)
> Comment on attachment 8451734 [details] [review]
> Pointer to Github PR
> https://github.com/mozilla-b2g/firefoxos-loop-client/pull/30
>
> Small comments to address. Please fix them and merge it! :)
Thanks for the review Borja!
Landed at:
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/f85f047bf321f914a1adba0f264fe2bb1788de0f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•