1034985 - Occasionally receive a notification from "Callscreen" which does nothing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Kevin Grandon :kgrandon]

No STR yet.

Occasionally I will receive a notification from "Callscreen", with the description of "Tap to open". After tapping on the notification nothing happens.

1 - "Callscreen" does not seem like a friendly user name for the  app, we should change that I think.
2 - The notification should work when tapped on, though I'm not sure what this should do.

I'll try to grab a screenshot next time I see it.

Comment 1

[Kevin Grandon :kgrandon]

Etienne - Sorry for the lack of a bug here, just wondering if you were aware of this, or would have any ideas of what could be causing it?

Comment 2

[Etienne Segonzac (:etienne)]

(In reply to Kevin Grandon :kgrandon from comment #1)
> Etienne - Sorry for the lack of a bug here, just wondering if you were aware
> of this, or would have any ideas of what could be causing it?

It's probably related to the multi attention screen support.
So if the STR don't involve an alarm and a call (the 2 current use for attention screens) it's probably a bug :)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: screenshot

Comment 4

[Kevin Grandon :kgrandon]

Etienne, Alive - any ideas based on the screenshot from Comment 3?

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Etienne is true -
The notification will only show when there are more than one attention screen
and callscreen is the elder so it create a notification.

The screenshot does make sense but we may need accurate STR. If there's an alarm comes over call then it is fine.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I see this a few times a week, but I haven't yet figured out what events lead to it happening.

Comment 7

[Etienne Segonzac (:etienne)]

Still no STR, but Gregor mentioned it's happening more often on low memory devices, which points to a potential error in the callscreen preloading code. I'll have a look today.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm seeing it on a flame, though, which is not low memory, although I do tend to explicitly close apps that I'm not using, including the Phone app.

(One other thought I had is that I haven't seen any phone-network-wide alerts (or whatever they're called) lately, and I wonder if they're somehow ending up as this instead of what they should be.)

Comment 9

[Etienne Segonzac (:etienne)]

I think I've got STR:

- get a phone call
- open the ui test app
- go to window.open -> window.open(url, name, 'attention')
- close the test attention screen
- the callscreen fake notification shows up when it shouldn't

Comment 10

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

It's a bit sad not to have tests for this, but the attention windows are coming! And will be well-tested :)

Comment 11

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/b72c9a8df7fdcb241821c2c485c838bae05df8bf

Comment 12

[Etienne Segonzac (:etienne)]

Comment on attachment 8456090 [details] [review]
Gaia PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):bug 988212

[User impact] if declined: if a user uses the alarm or any other attention-screen based feature (eg. loop) a "Callscreen" notification will frequently appear in the utility tray, tapping this notification does nothing and it can not be remove (but will disappear the next time the callscreen is opened).

[Testing completed]: Tested with dialer, clock and the UITest app

[Risk to taking this patch] (and alternatives if risky): low

[String changes made]: none

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/ccdfcc3257979748319af07533a951b1e7877f92