1035010 - [edge gestures] Unlocalized App name appear while switching App (without changing locale after reboot)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Théo Chevalier]

Bug 1022427 fixed some part of the issue. Remaining work is to fix this case:

1. Switch to French (or other locale)
2. Reboot the phone
3. Open Apps and switch between them: Names are in English

This is the most common case (User choosing a locale then sticking to it and rebooting his phone)

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

Wanna to take this one? Potential blocker.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Sure, take it.

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

waiting for test.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8451748 [details] [review]
PR to master

Hi Alive,
could you help to review this patch?
Thanks.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8451748 [details] [review]
PR to master

It seems the identification title is misleading us.

Etienne, I proposed to
* Use app name as identification title if it's an app.
* Use web title as identification title if it's not an app.

What do you think?

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8451748 [details] [review]
PR to master

Cancel until we have conclusion

Comment 7

[Etienne Segonzac (:etienne)]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #5)
> Comment on attachment 8451748 [details] [review]
> PR to master
> 
> It seems the identification title is misleading us.
> 
> Etienne, I proposed to
> * Use app name as identification title if it's an app.
> * Use web title as identification title if it's not an app.
> 
> What do you think?

Makes perfect sense!

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Etienne Segonzac (:etienne) from comment #7)
> (In reply to Alive Kuo [:alive][NEEDINFO!] from comment #5)
> > Comment on attachment 8451748 [details] [review]
> > PR to master
> > 
> > It seems the identification title is misleading us.
> > 
> > Etienne, I proposed to
> > * Use app name as identification title if it's an app.
> > * Use web title as identification title if it's not an app.
> > 
> > What do you think?
> 
> Makes perfect sense!

George, please do as described and ask review again. Thank you.

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8451748 [details] [review]
PR to master

Hi Alive,
I've updated my patch with test. could you take a look at it? Thanks.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8451748 [details] [review]
PR to master

r=me thanks!

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,

merged to master,
https://github.com/mozilla-b2g/gaia/commit/46d6cf87cc1a660c8a25378dee0e7b85ab8ce432

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/821b631130db71b635eb0a359c46e9e77d3e19a0

Comment 13

[Théo Chevalier]

Verified Fixed on 2.0 Flame

Gaia      5ba22d458fdb63bd72c59de53c701d0efe35c1e2
Gecko     https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/6fbc60a80c6d
BuildID   20140806000200
Version   32.0
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

Comment 14

[Shine(Leave from Mozilla)]

Attachment: video

This issue has been verified successfully on Flame 2.1
See attachment: Verify_1035010.MP4
Reproducing rate: 0/3

Flame 2.1 build:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0