1035034 - Fix typo in CertVerifier

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: fix-typo-in-CertVerifier.cpp

See patch.

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d696c6fe0a7

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8451409 [details] [diff] [review]
fix-typo-in-CertVerifier.cpp

Approval Request Comment
[Feature/regressing bug #]: bug 915930 or so.

[User impact if declined]: Unclear. Probably not a big impact either way because of the extra checks we do before/after this line of code, but I am nervous having this obviously-wrong line of code.

[Describe test coverage new/current, TBPL]: Current test coverage is pretty good, but obviously didn't catch this. Unfortunately, I am not sure how to write a reasonable test to trigger this behavior.

[Risks and why]: Very low risk, because this is a bug in fallback code for handling another error, and we have similar fallback code right after it.

[String/UUID change made/needed]: none.

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5d696c6fe0a7

Comment 4

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1f8ea4a62f1b
https://hg.mozilla.org/releases/mozilla-beta/rev/9c09b72ad255