Closed
Bug 1035034
Opened 10 years ago
Closed 10 years ago
Fix typo in CertVerifier
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: briansmith, Assigned: briansmith)
Details
Attachments
(1 file)
1.64 KB,
patch
|
cviecco
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
See patch.
Attachment #8451409 -
Flags: review?(cviecco)
Updated•10 years ago
|
Attachment #8451409 -
Flags: review?(cviecco) → review+
Assignee | ||
Comment 1•10 years ago
|
||
Thanks! https://hg.mozilla.org/integration/mozilla-inbound/rev/5d696c6fe0a7
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8451409 [details] [diff] [review] fix-typo-in-CertVerifier.cpp Approval Request Comment [Feature/regressing bug #]: bug 915930 or so. [User impact if declined]: Unclear. Probably not a big impact either way because of the extra checks we do before/after this line of code, but I am nervous having this obviously-wrong line of code. [Describe test coverage new/current, TBPL]: Current test coverage is pretty good, but obviously didn't catch this. Unfortunately, I am not sure how to write a reasonable test to trigger this behavior. [Risks and why]: Very low risk, because this is a bug in fallback code for handling another error, and we have similar fallback code right after it. [String/UUID change made/needed]: none.
Attachment #8451409 -
Flags: approval-mozilla-beta?
Attachment #8451409 -
Flags: approval-mozilla-aurora?
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5d696c6fe0a7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Attachment #8451409 -
Flags: approval-mozilla-beta?
Attachment #8451409 -
Flags: approval-mozilla-beta+
Attachment #8451409 -
Flags: approval-mozilla-aurora?
Attachment #8451409 -
Flags: approval-mozilla-aurora+
Comment 4•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/1f8ea4a62f1b https://hg.mozilla.org/releases/mozilla-beta/rev/9c09b72ad255
You need to log in
before you can comment on or make changes to this bug.
Description
•