According to mkaply, this broke when the fix for bug 92582 landed (the double PASV stuff). I'll attach a log he sent me, and a patch. I think that this is because we don't tear down the existing pasv connection before starting a new one. Bug 101128 sort of fixed this, but didn't wait for the connection to close. I have a patch which waits for the connection to close. I don't have access to an OS2 server to test it on - mkaply, can you try this out? In any event, its probably the correct behaviour.
I'm still getting the PASV error with this patch. I'm still working on getting an OS/2 FTP server outside the firewall. I'll let you know.
OK, mkaply sent me a log of ns4, which didn't help, so I looked through the mozclassic ftp code. Theres some stuff in there for sending a double PASV. However, its #ifdef'd out with the comment that it breaks mac ftp servers. Obviously it breaks os2 as well. So the next question is how does ns4 work on ftp.asus.com? The answer is that it doesn't, really. If a listing ends in a /, then its a directory. If its not, then we trey RETR'ing it. So ftp://ftp.asus.com/pub/ works, but ftp://ftp.asus.com/pub fails. (Except for vms, which has its own set of logic due to different path delimeters.) Does ie work with both ftp://ftp.asus.com/pub and ftp://ftp.asus.com/pub/ ? If so, can I please get a trace of both of those?
I have no problems with ftp.asus.com with the latest patch from bug 84242. Without it, it still seems to work although there are some assertions (second try works after internal reconnect, it seems).
Created attachment 56780 [details] [diff] [review] Proposed fix - it's ugly but it works - don't do PASV on an OS/2 server
Summary: Can't ftp to os2 servers → OS/2 support needed
Comment on attachment 56780 [details] [diff] [review] Proposed fix - it's ugly but it works - don't do PASV on an OS/2 server r=bbaetz. Sorry for letting this slip through the cracks. I still want someone (dougt?) to look at my comment #4, though.
Attachment #56780 - Flags: review+
Oh, one more comment regarding PASV: I got mkaply's traces, but they use PORT, so ie doesn't run into this.
-> patch author
Assignee: bbaetz → mkaply
Comment on attachment 56780 [details] [diff] [review] Proposed fix - it's ugly but it works - don't do PASV on an OS/2 server rs=darin
Attachment #56780 - Flags: superreview+
Fix checked in
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Mike: know of any public sites runing OS/2 that I can test w/? If not, but it works for you, can you mark this VERIFIED?
Keywords: testcase, verifyme
I'll mark it verified. We've tested with Os/2 sites.
Status: RESOLVED → VERIFIED
Any chance I can get a URL to a public OS/2 site? I'm finishing off my FTP test case re-write.
You need to log in before you can comment on or make changes to this bug.