1035153 - Prototype Dialer without tab bar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Doug Sherk (:drs) (inactive)]

Attachment: Dialer-removing tabs.pdf

Carrie has proposed a new sheet navigation layout for the dialer which removes the tabs at the bottom. We can prototype this and see how we like it.

Comment 1

[Doug Sherk (:drs) (inactive)]

Tentatively assigned to Germán and Paco.

Comment 2

[Doug Sherk (:drs) (inactive)]

This bug is just for a prototype to see if we like this. There's no need to do reviews or anything yet, and it can look really rough. I'm predicting that this will take about a week of man hours. We're doing this because we're really interested in the results, and it has the nice side effect of getting us more used to splashing in long-term project work during our sprints.

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

Hi Carrie, we have made (Paco has :p) some progress in the implementation of the prototype and some doubts came to our privileged :p minds:
  1. How should the "Dialer" app look like when there are no entries in the call log and no contacts (obviously no favourite contact either)? Should it show the "default view" including only the "All contacts" icon and showing the "No calls recorded. Start communicating now." in the call log area?
  2. Obviously the previous scenario should also consider the cases where there are favourite contacts but no entries in the call log or there are entries in the call log but no favourite contacts :)
  3. In case there are not enough entries in the call log to scroll, which would be the way to get the filters shown? :)
We have more doubts regarding the showing of the filters.
  4. Should the filters be shown when the user stops scrolling no matter if upwards or downwards? I guess yes.
  5. Related to 4 although it is probably more a visual thing, there are edge cases such as when the user does not scroll enough to get the "All Contacts" and "favorites" icons out of the screen. Which should be the behaviour on those cases regarding the showing of the filters?
  6. The current wireframes does not consider the edition (selection and deletion) of entries in the call log. Is the gear icon on the upper-right area supposed to do that?, I mean entering into edition mode.
  7. Probably more a technical question than an interaction one but since I think Anthony and Doug will read this, let me share it with you. On page 8 of the wireframes, it is mentioned that clicking on the "All contacts" icon let the user access the Contacts app. I mean this mean actually opening the Contacts app as an independent app, right? So the only way to get back to the Dialer app would be tapping on the Home button and clicking on the Dialer app or long tapping on the Home button and selecting the Dialer app from the open apps list, right?

Thank you very much!

Comment 4

[Anthony Ricaud (:rik)]

This is a prototype, let's not focus too much on the edge cases. Those are valid questions when we'll need to ship this. But this is just about prototyping the general case with lots of calls and lots of favorites.

(For going back to Dialer from Contacts, just swipe right from the left of the screen with Edge gestures)

Comment 5

[Doug Sherk (:drs) (inactive)]

(In reply to Anthony Ricaud (:rik) from comment #4)
> This is a prototype, let's not focus too much on the edge cases. Those are
> valid questions when we'll need to ship this. But this is just about
> prototyping the general case with lots of calls and lots of favorites.

I agree, but getting all of these issues written down for if/when we do decide to ship this is really good, and will help us cut down on the amount of iterations we'll need to make.

Paco and Germán, do you guys think this is at the point where we can post it and others can try it?

Comment 6

[Germán Toro del Valle (:gtorodelvalle)]

Since he is the one working on it... ;)

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

Yeah, yeah, in fact the preliminary version of the prototype was the one which made these questions pop up ;). On the other hand , it is important to take into account that edge (and not considered no so edge cases :p ) may cause a huge impact on the final design so we can discuss about them in parallel :)

Last but not least, Paco will prepare a video about the prototype as well as a some guidelines so anyone can try the "preliminary" version available :)

Comment 8

[Paco Rampas [:paco]]

For testing the prototype is recomended to do the following steps:

1- Install this patch in master: 
https://github.com/mozilla-b2g/gaia/pull/21989.patch

2- Instal the workload for having a lot of calls:
make reference-workload-light

3- Demo video: https://www.youtube.com/watch?v=bU4w0Q1fl5U

4- Enjoy

Comment 9

[Paco Rampas [:paco]]

Attachment: patch

Comment 10

[Doug Sherk (:drs) (inactive)]

Thanks for your work on this Paco, and for even going as far as making a video. Anthony will talk with Carrie about this and we'll decide on next steps.

Comment 11

[Doug Sherk (:drs) (inactive)]

I'm putting this back in last sprint since it was done then. Also setting ni Anthony as a reminder.

Comment 12

[Carrie Wang [New account: [e-mail]]]

Guys, this is super awesome!
I feel tears in my eyes! very impressive!
I'll start addressing the details that you've mentioned here. This is really helpful and I'm so happy to see the prototype!
Thanks! :)))))))

Comment 13

[Anthony Ricaud (:rik)]

Talked briefly with Carrie. She'll try the prototype on a phone and give us feedback.

Good job guys!

Comment 14

[Carrie Wang [New account: [e-mail]]]

Attachment: 2014-07-29-08-50-47.png

The prototype looks like this. The favorite contacts appeared 1 sec and then disappeared immediately.Don't know what's wrong with it.

Usually we need the link like this https://github.com/pacorampas/gaia/tree/prototype-dialer-1035153 to install patch. UXs don't really have code base cloned in our laptop. :( Anyways I've figured out how to get the correct link from the patch here. 

However, I tried to download from gitHub and even asked dev to pull branch for me, but looks like it doesn't work. I may need some help here.
Thanks!

Comment 15

[Anthony Ricaud (:rik)]

As Paco said in comment 8, you need to have some calls in your call log. Either call some people or load the reference workload via |make reference-workload-light|

Comment 16

[Paco Rampas [:paco]]

I think the problem of Carrie is for installing the patch. She doesn't have gaia clone or she doesn't know apply patches. What do you do as normal to install new branches or patches?

Comment 17

[Carrie Wang [New account: [e-mail]]]

No, check the attachment here, not only call logs but also the contacts didn't show up on the top of the page. I did install the patch and ask dev in TPO to install it for me too. This issue happened every time. 

My flame has been flashed to the latest version. Does the patch conflict with this version?

Comment 18

[Carrie Wang [New account: [e-mail]]]

Okay, solved the problem with Rik via IRC. Now I can start trying it. Thanks!

Comment 19

[Carrie Wang [New account: [e-mail]]]

Attachment: Dialer-removing tabs V0.1.pdf

Hi, 

Since we are going to conduct a user testing on Aug 18th and this feature will be one of the test case, I'd like to tweak some mild issues first and then we can collect some feedback from users and maybe correspondingly revise the design afterwards. 

Attached is the updated spec. I want to fix 2 issues for now:

1. We want to show the filter (All/ Missed) in default view. So that will be Favorites -> Filters -> Call logs.

2. The filter should disappear while user is scrolling the page. 

Do you think these changes can be done before the user testing?
In addition, is it possible for not using our "fake favorite contacts" and allow users to add contacts from Contact App?

If we can't make it before the test, we can still adopt the old patch and I think that should be ok too.  
Thanks!

Comment 20

[Paco Rampas [:paco]]

> 1. We want to show the filter (All/ Missed) in default view. So that will be
> Favorites -> Filters -> Call logs.
> 
> 2. The filter should disappear while user is scrolling the page. 
> 
> Do you think these changes can be done before the user testing?
Yes, they both changes can be done for 18th.

> In addition, is it possible for not using our "fake favorite contacts" and
> allow users to add contacts from Contact App?
This change I think is not possible (for me). I'm in PTO from 14 to 24 and I don't have enough time.

Comment 21

[Carrie Wang [New account: [e-mail]]]

Hi Paco, 


Thank you! :)
For the second part, I think it's ok. I can take some tricky steps to make users feel that they add those contacts as favorites by their own. Can you remove some contacts from the favorites? I think  three of them will be enough. Thanks!

Comment 22

[Doug Sherk (:drs) (inactive)]

I may be able to squeeze in some time to finish this if Paco can't get it done before he leaves.

Comment 23

[Stephany Wilkes]

Can someone post instructions for how best to view this patch? We'll need to put it on a few devices for user testing. I've cloned Paco's repo and found the prototype-dialer-1035153 branch, but can't seem to get the patch on the device with our usual make reset-gaia APP=dialer flow. Thank you!

Comment 24

[Paco Rampas [:paco]]

> but can't seem to get the patch on the
> device with our usual make reset-gaia APP=dialer flow. Thank you!
Have you tried "make install-gaia APP=communications"? This should work fine. If it doesn't work you can try "make install-gaia" or "make reset-gaia", the two last options are slower but should work.

Comment 25

[Paco Rampas [:paco]]

> Can you
> remove some contacts from the favorites? I think  three of them will be
> enough.

Ok, I have only kept three fav contacts. Also, I have updated the patch with the two new changes.

Comment 26

[Carrie Wang [New account: [e-mail]]]

Hi Steph, 

I think the updated patch is "gaia-prototype-dialer-1035153-v1".
Make sure you install the right one. Thanks!

Comment 27

[Carrie Wang [New account: [e-mail]]]

Attachment: [2.2 Dialer]Removing tabs in Call log V0.2.pdf