1035296 - Make protocol.js pass error messages for unknownErrors

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect)

Description

[Joe Walker [:jwalker]]

Better error message needed.

Comment 1

[Joe Walker [:jwalker]]

Attachment: 0001-Bug-1035296-Make-protocol.js-pass-error-messages-for.patch

Comment 2

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=05d109f05f31

Comment 3

[Joe Walker [:jwalker]]

In an actor throws an exception, protocol.js catches it and passes a packet like this:

    {
      error: "unknownError",
      message: ex.message
    }

And then in the client, the promise was resolved like this:

    if (packet.error) reject(packet.error);

Which means that we lose everything there is to know about the original exception. This change passes on the error message, which is particularly useful to GCLI which doesn't then have to have some magic to work out what might have gone wrong.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/114268fab626

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/114268fab626

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Backed out per the discussion in bug 1038279. Sorry Joe, this work is very righteous :(

https://hg.mozilla.org/mozilla-central/rev/31c5d0a5115d

Comment 7

[Joe Walker [:jwalker]]

Attachment: 0001-Bug-1035296-Make-protocol.js-pass-error-messages-for.patch v2

Clean on try: https://tbpl.mozilla.org/?tree=Try&rev=6d98639e8e78
Doesn't seems to throw up the false +ves that the previous patch did

Comment 8

[Joe Walker [:jwalker]]

https://hg.mozilla.org/integration/fx-team/rev/65ae48644b2e
https://tbpl.mozilla.org/?tree=Fx-Team&rev=65ae48644b2e

Comment 9

[Sami Jaktholm]

Noticed while checking recent changes that rev 65ae48644b2e seem to be a no-op ('message' is not used anywhere). Something must be missing from the patch, probably
-        deferred.reject(packet.error);
+        deferred.reject(message);

Comment 10

[Joe Walker [:jwalker]]

Attachment: 0001-Bug-1035296-Part-2-Make-protocol.js-pass-error-messa.patch

Thanks Sami, well spotted.
Panos, this also removes the 'Protocol error' part in GCLI.

Comment 11

[Joe Walker [:jwalker]]

https://hg.mozilla.org/integration/fx-team/rev/c5be930c66e3
https://tbpl.mozilla.org/?tree=Fx-Team&rev=c5be930c66e3

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Backed out for mochitest-dt orange.
https://hg.mozilla.org/integration/fx-team/rev/1abe173b2c8b

https://tbpl.mozilla.org/php/getParsedLog.php?id=44982654&tree=Fx-Team

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/65ae48644b2e

Comment 14

[Joe Walker [:jwalker]]

https://hg.mozilla.org/integration/fx-team/rev/215da263fe06

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/215da263fe06