Closed Bug 1035335 Opened 10 years ago Closed 10 years ago

Searches for numbers result in a search conducted on the actual entire Google Search URL no matter the engine

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
32 Branch
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox31 unaffected, firefox32 verified, firefox33 verified, fennec32+)

Status:
VERIFIED FIXED
Milestone:
Firefox 33
Tracking Flags:
Tracking Status
firefox31 --- unaffected
firefox32 --- verified
firefox33 --- verified
fennec 32+ ---

People

(Reporter: kmag, Assigned: bnicholson)

References

Details

(Keywords: regression, reproducible)

Attachments

(1 file)

Don't convert number query for searches
1.22 KB, patch
mfinkle
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
This happens in the latest Aurora 32, but not the latest beta 31:

1) Enter a number in the urlbar.
2) Click any of the search engines from the suggestion list.
3) The query on the resulting search page is a Google search URL for the term (whether searching with a Google engine or not), rather than the term itself ("https://www.google.com/search?q=123&ie=utf-8&oe=utf-8&a1=t&rls=org.mozilla:en-US:unofficial")

I noticed this when attempting to search for a USPS tracking number.
Nice catch.
tracking-fennec: --- → ?
status-firefox31: --- → unaffected
status-firefox32: --- → affected
status-firefox33: --- → affected
Keywords: reproducible
Re-summarizing.

So, if you search up '123', no matter the engine you use you'll see a search conducted on the actual entire Google search URL.
Summary: Searches for numbers result in search for Google search URL instead → Searches for numbers result in a search conducted on the actual entire Google Search URL no matter the engine
Flags: in-moztrap?(fennec)
URL: 123
URL: 123
Assignee: nobody → bnicholson
tracking-fennec: ? → 32+
We should avoid converting these searches if the user clicked a search engine.
Attachment #8454097 - Flags: review?(mark.finkle)
Comment on attachment 8454097 [details] [diff] [review]
Don't convert number query for searches

Would be nice to think of some simple tests we could run.
Attachment #8454097 - Flags: review?(mark.finkle) → review+
Comment on attachment 8454097 [details] [diff] [review]
Don't convert number query for searches

Approval Request Comment
[Feature/regressing bug #]: bug 993705
[User impact if declined]: Number searches are broken when clicking a search engine
[Describe test coverage new/current, TBPL]: Tested fix locally
[Risks and why]: Very low risk; adds a check to the fix from bug 993705 to skip search engine clicks
[String/UUID change made/needed]: None
Attachment #8454097 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/b1fe950c2289
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Keywords: verifyme
Attachment #8454097 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed in builds:
Firefox for Android 32.0a2 (2014-07-15)
Firefox for Android 33.0a1 (2014-07-15)
Device:
Galaxy Nexus (Android 4.2.1)
Status: RESOLVED → VERIFIED
status-firefox32: fixed → verified
status-firefox33: fixed → verified
Keywords: verifyme
Test case added in Moztrap:
https://moztrap.mozilla.org/manage/case/14079/ - Search for numbers
Flags: in-moztrap?(fennec) → in-moztrap+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: