1035336 - [UI] Cleanup jQuery UI spaghetti

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Schalk Neethling [:espressive]]

Currently in the crashstats webapp, and perhaps some of the other apps as well, we are using a bunch off different versions of jQuery UI, conflicting jQuery UI CSS and then there is Flora table sorter thrown in for a little extra pain.

Clearly this needs clean up to ensure we can manage all the dependencies easier, cleanly mix and match the different available UI widgets, without style clashes and have a clear upgrade path.

Comment 1

[Peter Bengtsson [:peterbe]]

It's really hard to win with jQuery UI. There is no good way to win. Either you lump everything together in a MASSIVE blob of js or you try to split things up specifically and it gets itself into filing bugs just like this. 

What about abandoning jQuery UI altogether and get on the Bootstrap JS bandwagon?

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

+1 on abandoning jQuery UI. I'm not very opinionated on bootstrap or any other solution, but I did hear that bootstrap was quite heavy as well. Isn't there an even better solution out there?

Comment 3

[Schalk Neethling [:espressive]]

(In reply to Peter Bengtsson [:peterbe] from comment #1)
> It's really hard to win with jQuery UI. There is no good way to win. Either
> you lump everything together in a MASSIVE blob of js or you try to split
> things up specifically and it gets itself into filing bugs just like this. 
> 
> What about abandoning jQuery UI altogether and get on the Bootstrap JS
> bandwagon?

You are correct however, an initial cleanup will be a win for right now, and unblock me on some pieces of work I need to do. In fact, for most of socorro, not sure about super search and areas like the admin, we probably do not even need a big ui widget toolkit and can probably build a lot of these widgets ourslves, with a lot less code and have more control.

Comment 4

[Schalk Neethling [:espressive]]

(In reply to Adrian Gaudebert [:adrian] from comment #2)
> +1 on abandoning jQuery UI. I'm not very opinionated on bootstrap or any
> other solution, but I did hear that bootstrap was quite heavy as well. Isn't
> there an even better solution out there?

There are micro libraries, but I reckon we can get far with rolling our own as needed.

Comment 5

[Schalk Neethling [:espressive]]

Also, as part of the cleanup I will be documenting a lot more aspects of the UI and also defining our needs in terms of UI widget etc. So, we will be able to make a more informed decisions once I am done with this.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/6d8948f5fab44f0ce7d26d3ff6015c8f6c4929a9
Fix Bug 1035336, fix jQueryUI spaghetti and upgrade to latest

https://github.com/mozilla/socorro/commit/147ffc9cace88d3d6ce34d8eaa02a807f4a80aa1
Merge pull request #2306 from ossreleasefeed/bug1035336-cleanup-jquery-ui-spaghetti

Fix Bug 1035336, fix jQueryUI spaghetti and upgrade to latest