1035337 - Measure number of times infobar is hidden due to "Never translate this language/site"

Status: VERIFIED FIXED

(Firefox :: Translations, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Our current measurements for language detection always count a translation opportunity, even if the infobar is not displayed (only the URLbar icon) due to the user having opted-out to that language/site.

In order for us to better understand how much the offer is being accepted/ignored, we should take that into account somehow. I don't think we need a breakdown of languages or separating it by type (site or language). Just a counter for "there was an opportunity but it was not presented due to user choice".

Comment 1

[Steven MacLeod [:smacleod]]

Marco, please add me to this bug for the iteration.

Comment 2

[Marco Mucci [:MarcoM]]

Added to iteration 33.3.  Steven, can you mark this bug as either [qa+] or [qa-] for QA verification.

Comment 3

[Steven MacLeod [:smacleod]]

Attachment: Part 1 - FHR and recording API

This patch introduces API to record when the infobar is hidden due to "Never translate this language/site".

Comment 4

[Steven MacLeod [:smacleod]]

Attachment: Part 2 - Make use of the API introduced in part 1

This patch actually calls the API to record when the infobar is hidden due to "Never translate this language/site".

Comment 5

[Steven MacLeod [:smacleod]]

Part 1: https://hg.mozilla.org/integration/fx-team/rev/6c615e27667e
Part 2: https://hg.mozilla.org/integration/fx-team/rev/723baaade90b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6c615e27667e
https://hg.mozilla.org/mozilla-central/rev/723baaade90b

Comment 7

[Bogdan Maris, Desktop Test Engineering]

Did a little exploratory testing around 'autoRejectedTranslationOffer' metric and it works as expected on latest Nightly using Windows 7 64bit, Mac OS X 10.9.4 and Ubuntu 13.04 64bit.

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8454229 [details] [diff] [review]
Part 1 - FHR and recording API

Approval Request Comment
[Feature/regressing bug #]: translation trial
[User impact if declined]: This measurement will help us understand a lot better the number of times the translation infobar is presented to the user, by letting us know how many times we hit a site/language that the user has opt-ed out of translation (just a counter of number of times this happens is tracked, no website or language info)
[Describe test coverage new/current, TBPL]: verified by QA, has tests
[Risks and why]: none
[String/UUID change made/needed]: none

Comment 9

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8454230 [details] [diff] [review]
Part 2 - Make use of the API introduced in part 1

Approval Request Comment
The two patches go together. See previous comment with the approval request.

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8454229 [details] [diff] [review]
Part 1 - FHR and recording API

Aurora+

Comment 11

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/40ef545ebd79
https://hg.mozilla.org/releases/mozilla-aurora/rev/0874ec920408

Comment 12

[Bogdan Maris, Desktop Test Engineering]

Also verified on Windows 7 64bit, Mac OS X 10.9.4 and Ubuntu 13.04 64bit using latest Aurora.