Closed Bug 1035337 Opened 6 years ago Closed 6 years ago

Measure number of times infobar is hidden due to "Never translate this language/site"

Categories

(Firefox :: Translation, defect)

defect
Not set
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 33
Iteration:
33.3
Tracking Status
firefox30 --- unaffected
firefox31 --- unaffected
firefox32 --- verified
firefox33 --- verified

People

(Reporter: Felipe, Assigned: smacleod)

Details

Attachments

(2 files)

Our current measurements for language detection always count a translation opportunity, even if the infobar is not displayed (only the URLbar icon) due to the user having opted-out to that language/site.

In order for us to better understand how much the offer is being accepted/ignored, we should take that into account somehow. I don't think we need a breakdown of languages or separating it by type (site or language). Just a counter for "there was an opportunity but it was not presented due to user choice".
Flags: firefox-backlog+
Points: --- → 2
Marco, please add me to this bug for the iteration.
Assignee: nobody → smacleod
Status: NEW → ASSIGNED
Flags: needinfo?(mmucci)
Added to iteration 33.3.  Steven, can you mark this bug as either [qa+] or [qa-] for QA verification.
Iteration: --- → 33.3
QA Whiteboard: [qa?]
Flags: needinfo?(mmucci)
QA Whiteboard: [qa?] → [qa+]
QA Contact: bogdan.maris
This patch introduces API to record when the infobar is hidden due to "Never translate this language/site".
Attachment #8454229 - Flags: review?(felipc)
This patch actually calls the API to record when the infobar is hidden due to "Never translate this language/site".
Attachment #8454230 - Flags: review?(felipc)
Attachment #8454229 - Flags: review?(felipc) → review+
Attachment #8454230 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/6c615e27667e
https://hg.mozilla.org/mozilla-central/rev/723baaade90b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Did a little exploratory testing around 'autoRejectedTranslationOffer' metric and it works as expected on latest Nightly using Windows 7 64bit, Mac OS X 10.9.4 and Ubuntu 13.04 64bit.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
Comment on attachment 8454229 [details] [diff] [review]
Part 1 - FHR and recording API

Approval Request Comment
[Feature/regressing bug #]: translation trial
[User impact if declined]: This measurement will help us understand a lot better the number of times the translation infobar is presented to the user, by letting us know how many times we hit a site/language that the user has opt-ed out of translation (just a counter of number of times this happens is tracked, no website or language info)
[Describe test coverage new/current, TBPL]: verified by QA, has tests
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8454229 - Flags: approval-mozilla-aurora?
Comment on attachment 8454230 [details] [diff] [review]
Part 2 - Make use of the API introduced in part 1

Approval Request Comment
The two patches go together. See previous comment with the approval request.
Attachment #8454230 - Flags: approval-mozilla-aurora?
Comment on attachment 8454229 [details] [diff] [review]
Part 1 - FHR and recording API

Aurora+
Attachment #8454229 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8454230 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Also verified on Windows 7 64bit, Mac OS X 10.9.4 and Ubuntu 13.04 64bit using latest Aurora.
You need to log in before you can comment on or make changes to this bug.