1035456 - Building fails in OSX 10.10

Status: RESOLVED DUPLICATE of bug 1045231

(Core :: WebRTC, defect)

Description

[Marcos Caceres [:marcosc]]

Attachment: report.txt

Failing to build on OSX 10.10 Beta 2... 

Steps to reproduce:

1. ./mach build

Expected Gecko to build.

Comment 1

[Nomis101]

I am seeing this as well. On DP 5, Xcode6-Beta5. The errors are as followed:

In file included from /Volumes/Developer/comm-release/mozilla/media/mtransport/third_party/nICEr/src/stun/stun_codec.c:52:
    if (ctx->request_ct > ctx->maximum_transmits) {
/Volumes/Developer/comm-release/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/util/byteorder.h        ~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~:
42:7: error: 
      expected ')'
UINT8 htonll(UINT8 hostlonglong);
      ^
/Developer/SDKs/MacOSX10.10.sdk/usr/include/sys/_endian.h:141:25: note: 
      expanded from macro 'htonll'
#define htonll(x)       __DARWIN_OSSwapInt64(x)


and


/Volumes/Developer/comm-release/mozilla/media/mtransport/third_party/nICEr/../nrappkit/src/util/byteorder.h:42:7: error: 
      conflicting types for '__builtin_constant_p'
UINT8 htonll(UINT8 hostlonglong);
      ^
/Developer/SDKs/MacOSX10.10.sdk/usr/include/sys/_endian.h:141:25: note: 
      expanded from macro 'htonll'
#define htonll(x)       __DARWIN_OSSwapInt64(x)


So, the error is referring to this file:
http://hg.mozilla.org/mozilla-central/file/18f408a5984e/media/mtransport/third_party/nrappkit/src/util/byteorder.h


In _endian.h from 10.10 SDK there are now two lines (140/141) that didn't exist in all older SDKs:
#define ntohll(x)       __DARWIN_OSSwapInt64(x)
#define htonll(x)       __DARWIN_OSSwapInt64(x)

Comment 2

[Daniel Holbert [:dholbert]]

Did the "error: expected ')'" issue, in comment 1 here, end up being fixed by bug 1045231?

(Bug 1045231 comment 1 suggests that they might be the same underlying problem.)

If so, we should probably dupe this to that bug, rather than leaving it open.

Comment 3

[Alex Vincent [:WeirdAl]]

I can confirm the build bustage is fixed by bug 1045231's patch... but it is not sufficient.  There's at least one more bustage, fixed in bug 1044497.