Closed Bug 1035457 Opened 10 years ago Closed 10 years ago

Remove duplicated 'make bootstrap' calls coming from 'scripts/build.sh'

Categories

(Socorro :: Infra, task)

x86_64
Linux
task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bramwelt, Assigned: bramwelt)

Details

'scripts/build.sh' calls 'make test' which, within make, calls 'make bootstrap'. 'scripts/build.sh' later calls 'scripts/rabbitmq-integration-tests.sh', and 'scripts/elasticsearch-integration-tests.sh' which both call 'make bootstrap'. As the ES and RabbitMQ integration tests are only being run from build.sh, which sets up the environment before running those tests, it make sense that they should not later call 'make bootstrap' again.
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/96a46d41e1ece6db3ddeba3078507643bc3639f0 fix bug 1035457 - Remove multiple 'make bootstrap' calls `build.sh` sets up the build environment (which includes running `make bootstrap`) and runs elasticsearch and rabbitmq integration tests, which in turn run `make bootstrap` again. https://github.com/mozilla/socorro/commit/2c008c4dd9ca7832bef2bb29398e91c2b36f4463 Merge pull request #2169 from bramwelt/fix-1035457-build-duplications fix bug 1035457 - Remove multiple 'make bootstrap' calls
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee: nobody → tbramwell
Target Milestone: --- → 93
You need to log in before you can comment on or make changes to this bug.