1035505 - [webvtt] HTMLTrackElement should fire a 'load' event not a 'loaded'

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Rick Eyre (:reyre)]

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#start-the-track-processing-model step 10 specifies that a 'load' event should be fired at the HTMLTrackElement if it successfully loads, not a 'loaded' event.

Comment 1

[Rick Eyre (:reyre)]

Attachment: HTMLTrackElement should fire a 'load' event not a 'loaded' event.

Comment 2

[Rick Eyre (:reyre)]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=b8c3d544ba05

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8452041 [details] [diff] [review]
HTMLTrackElement should fire a 'load' event not a 'loaded' event.

Review of attachment 8452041 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

When exactly is this event meant to fire. I tried adding listeners to a static <track> element at https://people.mozilla.org/~rgiles/2014/sintel-test.html but the event alerts don't fire on Firefox, Chrome or Nightly. Does this only work if we've added the listener before the track is added to the media element?

Comment 4

[Rick Eyre (:reyre)]

Thanks for review Ralph.

(In reply to Ralph Giles (:rillian) from comment #3)

> Looks good to me.
> 
> When exactly is this event meant to fire. I tried adding listeners to a
> static <track> element at
> https://people.mozilla.org/~rgiles/2014/sintel-test.html but the event
> alerts don't fire on Firefox, Chrome or Nightly. Does this only work if
> we've added the listener before the track is added to the media element?

I believe so. The event fires as soon as the WebVTT file has been downloaded and parsed so if that happens quicker then it takes to add the event you won't get notified.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1a49305c6236

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1a49305c6236