Closed Bug 1035505 Opened 6 years ago Closed 6 years ago

[webvtt] HTMLTrackElement should fire a 'load' event not a 'loaded'

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: reyre, Assigned: reyre)

References

()

Details

(Keywords: dev-doc-needed)

Attachments

(1 file)

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#start-the-track-processing-model step 10 specifies that a 'load' event should be fired at the HTMLTrackElement if it successfully loads, not a 'loaded' event.
Comment on attachment 8452041 [details] [diff] [review]
HTMLTrackElement should fire a 'load' event not a 'loaded' event.

Review of attachment 8452041 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

When exactly is this event meant to fire. I tried adding listeners to a static <track> element at https://people.mozilla.org/~rgiles/2014/sintel-test.html but the event alerts don't fire on Firefox, Chrome or Nightly. Does this only work if we've added the listener before the track is added to the media element?
Attachment #8452041 - Flags: review?(giles) → review+
Thanks for review Ralph.

(In reply to Ralph Giles (:rillian) from comment #3)

> Looks good to me.
> 
> When exactly is this event meant to fire. I tried adding listeners to a
> static <track> element at
> https://people.mozilla.org/~rgiles/2014/sintel-test.html but the event
> alerts don't fire on Firefox, Chrome or Nightly. Does this only work if
> we've added the listener before the track is added to the media element?

I believe so. The event fires as soon as the WebVTT file has been downloaded and parsed so if that happens quicker then it takes to add the event you won't get notified.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1a49305c6236
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.