[email/IMAP] Ensure lastSyncedAt is not updated in the failure case

ASSIGNED
Assigned to

Status

Firefox OS
Gaia::E-Mail
ASSIGNED
3 years ago
3 years ago

People

(Reporter: asuth, Assigned: asuth)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

3 years ago
During investigation of bug 1018828 code reading suggests that we probably call markSyncRange in the IMAP case regardless of whether there is an error or not.  We definitely don't have a unit test that verifies lastSyncedAt does not change in the failure case.

I'll add a unit test and assuming that proves we are broken, I'll fix the bug.  If the test says we're fine, I'll add some comments so subsequent code reading does not get misled too.

POP3 may or may not be affected by something similar; I'm filing a bug for that one, and it may or may not be able to rely on new test coverage from this bug.
You need to log in before you can comment on or make changes to this bug.