1035634 - [Keyboard] Keyboard Settings should follow recommendation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P3)

Description

[Omega Feng [:Omega] [:馮於懋]]

Keyboard Settings should follow recommendation, like settings structure, Number IME visibility, etc.

Comment 1

[Omega Feng [:Omega] [:馮於懋]]

Arthur, can you comment on this?

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/21490

WIP, still need to update the tests.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8452828 [details]
link to https://github.com/mozilla-b2g/gaia/pull/21490

The patch merged the enabled layout panel to the keyboard panel based on the new UX spec. 

EJ, could you help review the patch? The patch simply moved the code from one place to another.

Zac, I also updated the UI tests to reflect the flow change.

Thanks!

Comment 4

[Florin Strugariu [:Bebe]]

Comment on attachment 8452828 [details]
link to https://github.com/mozilla-b2g/gaia/pull/21490

The UI tests looks OK

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Arthur, I did check the code and they all look nice. But there is a little bit UI inconsistent compared with UX spec, can you check the comment on Github ? THanks !

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

If what you meant is the style, we will have a separate bug to change the styles of all menu items.

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8452828 [details]
link to https://github.com/mozilla-b2g/gaia/pull/21490

Thanks for the patch, Arthur.

r+++

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thank you, EJ!

master: 8712915c5d36f681308afb475ea387af185e3715