Created attachment 8453027 [details] [review] Link to github PR
Comment on attachment 8453027 [details] [review] Link to github PR Looks good beside a small possible improvement on config definition.
Attachment #8453027 - Flags: feedback?(tarek) → feedback+
Comment on attachment 8453027 [details] [review] Link to github PR I added a few comments here and there, declining the review for now, I believe this doesn't track http errors + there are a few nits that needs to be addressed. Feel free to r? me again when you have something updated!
Attachment #8453027 - Flags: review- → review?(alexis+bugs)
Comment on attachment 8453027 [details] [review] Link to github PR Well, this has already been merged, but I think it could be better, so I'm letting a r-. No big deal, but we should avoid having globals whenever we can. No big deal, still, but please avoid merging with a pending review (even if this takes a few days). In case of emergency, feel free to poke me so it can go faster.
Oh sorry about that. I didn't remember I had a pending review on it. I am going to fix your review. Thank you for that.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Verified in code.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.