1035668 - Add Acision SMS Gateway alternative.

Status: VERIFIED FIXED

(Cloud Services Graveyard :: MobileID, defect)

Comment 1

[Rémy Hubscher (:natim)]

Attachment: Link to github PR

Comment 2

[Tarek Ziadé (:tarek)]

Comment on attachment 8453027 [details] [review]
Link to github PR

Looks good beside a small possible improvement on config definition.

Comment 3

[Alexis Metaireau (:alexis)]

Comment on attachment 8453027 [details] [review]
Link to github PR

I added a few comments here and there, declining the review for now, I believe this doesn't track http errors + there are a few nits that needs to be addressed.

Feel free to r? me again when you have something updated!

Comment 4

[Alexis Metaireau (:alexis)]

Comment on attachment 8453027 [details] [review]
Link to github PR

Well, this has already been merged, but I think it could be better, so I'm letting a r-.

No big deal, but we should avoid having globals whenever we can.
No big deal, still, but please avoid merging with a pending review (even if this takes a few days).

In case of emergency, feel free to poke me so it can go faster.

Comment 5

[Rémy Hubscher (:natim)]

Oh sorry about that. I didn't remember I had a pending review on it.
I am going to fix your review. Thank you for that.

Comment 6

[Rémy Hubscher (:natim)]

https://github.com/mozilla-services/msisdn-gateway/commit/2a80d49b9750a8976b3ecbcb029a430c22d6d35e

Comment 7

[James Bonacci [:jbonacci]]

Verified in code.