Add Acision SMS Gateway alternative.

VERIFIED FIXED

Status

Cloud Services
MobileID
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: natim, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa?])

Attachments

(1 attachment)

Comment hidden (empty)
Whiteboard: [qa?]
(Reporter)

Comment 1

3 years ago
Created attachment 8453027 [details] [review]
Link to github PR
Attachment #8453027 - Flags: review?(alexis+bugs)
Attachment #8453027 - Flags: feedback?(tarek)
(Reporter)

Updated

3 years ago
Status: NEW → ASSIGNED
Comment on attachment 8453027 [details] [review]
Link to github PR

Looks good beside a small possible improvement on config definition.
Attachment #8453027 - Flags: feedback?(tarek) → feedback+
Comment on attachment 8453027 [details] [review]
Link to github PR

I added a few comments here and there, declining the review for now, I believe this doesn't track http errors + there are a few nits that needs to be addressed.

Feel free to r? me again when you have something updated!
Attachment #8453027 - Flags: review?(alexis+bugs) → review-
(Reporter)

Updated

3 years ago
Attachment #8453027 - Flags: review- → review?(alexis+bugs)
Comment on attachment 8453027 [details] [review]
Link to github PR

Well, this has already been merged, but I think it could be better, so I'm letting a r-.

No big deal, but we should avoid having globals whenever we can.
No big deal, still, but please avoid merging with a pending review (even if this takes a few days).

In case of emergency, feel free to poke me so it can go faster.
Attachment #8453027 - Flags: review?(alexis+bugs) → review-
(Reporter)

Comment 5

3 years ago
Oh sorry about that. I didn't remember I had a pending review on it.
I am going to fix your review. Thank you for that.
(Reporter)

Comment 6

3 years ago
https://github.com/mozilla-services/msisdn-gateway/commit/2a80d49b9750a8976b3ecbcb029a430c22d6d35e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Verified in code.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.