Closed Bug 1035689 Opened 10 years ago Closed 10 years ago

update_crash_adu_by_build_signature() SP should enforce minimum build ID length

Categories

(Socorro :: Database, task)

Product:
Socorro
Component:
Database
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rhelmer, Assigned: rhelmer)

References

Details

(Whiteboard: [DB Change])

If we don't do this, we'll periodically hit things like bug 1035631 which will halt reporting until fixed. Alternatively, we could make update-crash-adu-by-build-signature OK with this - it is parsing the build ID as a date, so not sure what date we'd put in its place...
Looks like this is already being attempted in https://github.com/mozilla/socorro/blob/master/socorro/external/postgresql/raw_sql/procs/update_crash_adu_by_build_signature.sql#L74 It appears that the "keep these out of reports_clean" ship has already sailed for the time being since this is being used in other places.
Status: NEW → ASSIGNED
Summary: update_reports_clean() SP should enforce minimum build ID length → update_crash_adu_by_build_signature() SP should enforce minimum build ID length
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/a5ed28b69916d7600871f930b610efe56acb6af4 fix bug 1035689 - ensure minimum build ID length when querying reports_clean https://github.com/mozilla/socorro/commit/a7634080038b7973e04291584e39eca04da3a03e Merge pull request #2188 from rhelmer/bug1035689-ignore-bad-build_ids fix bug 1035689 - ensure minimum build ID length when querying reports_c...
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95
Whiteboard: [DB Change]
Blocks: 1035631
This landed but migration was not run on prod. Doing it now.
[postgres@socorro1 application]$ $PYTHON $SOCORRO_DIR/socorro-virtualenv/bin/alembic -c ~/.alembic-config upgrade 18805d64cf6 INFO [alembic.migration] Context impl PostgresqlImpl. INFO [alembic.migration] Will assume transactional DDL. /data/socorro/socorro-virtualenv/lib/python2.6/site-packages/alembic/util.py:189: UserWarning: Revision 321a815df1c7 referenced from 321a815df1c7 -> 5e14d46c725, bug 855423 change RAISE EXCEPTION to RAISE NOTICE is not present warnings.warn(msg) INFO [alembic.migration] Running upgrade 391e42da94dd -> 18805d64cf6, bug 1035689 - enforce minimum build ID length in update_crash_adu_by_build_signature [postgres@socorro1 application]$
You need to log in before you can comment on or make changes to this bug.