Closed Bug 1035723 Opened 10 years ago Closed 10 years ago

[Homescreen] - remove unused images

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: pivanov, Assigned: pivanov)

References

Details

Attachments

(1 file)

patch for Gaia/master
46 bytes, text/x-github-pull-request
vingtetun
: review+
Details | Review 
We need to check following images:

apps/homescreen/style/images/rocketbar.png

??? - we need to double check this
Attached file patch for Gaia/master — 

        Attachment #8455286 -
        Flags: review?(21)

    
    

    
  
I feel like we should leave the old homescreen alone until we decide to remove it entirely, I have a feeling this image may be used, but its inconvenient to test since we have to switch our the homescreen.

As for removing it entirely, its currently quite useful as we look to enable customisable homescreens, whoever works on that bug should make that call though

    
    

    
  
Comment on attachment 8455286 [details] [review]
patch for Gaia/master

I don't think it hurts to remove it, while I agree that spending time on the new homescreen is likely more important.

        Attachment #8455286 -
        Flags: review?(21) → review+

    
    

    
  
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/b15d20209fd0b1a5fe0cd879867d9a1332dbfd68
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: