1035758 - AudioOffloadPlayback: Music app progress bar resets when seek during pause

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[vasanth]

Attachment: Fix-seek-bar-reset-seek-during-pause.patch

STR:
----
1. Open the Music App.
2. Play an AAC/MP3 clip with length more than 60secs. (only in offload playback)
3. Pause the playback.
4. Perform seek.
5. The progress bar pointer moves to beginning of the progress bar.
6. Resume the playback. But the audio resumes from the the seeked position in Step4.

Analysis
--------
It's a bug in my code [1] uncovered by fix for [2]

Always MediaOmxDecoder::PlaybackPositionChanged() should be called during offload playback,
but since I didn't make it virtual, MediaDecoder::PlaybackPositionChanged() 
was called when seek completed [3], which resets seek bar in UI.

Also made sure all other functions overridden in child (MediaOmxDecoder) are declared virtual in parent (MediaDecoder)

Attached the fix. 

[1] https://bugzil.la/976172
[2] https://bugzil.la/778077
[3] http://dxr.mozilla.org/mozilla-central/source/content/media/MediaDecoder.cpp#1077

Comment 1

[vasanth]

Hi Robert, 
Could you please give try run if needed? 
Else can we add checkin-needed?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://tbpl.mozilla.org/?tree=Try&rev=aa768f76f791

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

You should get level 1 access so you can tryserver things yourself :-)

Comment 4

[vasanth]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #3)
> You should get level 1 access so you can tryserver things yourself :-)

Yep. Trying for that.
Starred 2 failures in try build. Adding checkin-needed flag

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8412692a3b5

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a8412692a3b5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9297a56e155e

Comment 8

[Robert Mead [:RobertM]]

covered by this test case because it covers slider bar(scrubber) manipulation:
https://moztrap.mozilla.org/manage/case/8519/

Comment 9

[KTucker [:KTucker][Inactive 3/4/2016]]

Test case has been added to moztrap:

https://moztrap.mozilla.org/manage/case/14324/