1035761 - [B2G][Cost Control] support 24 hour time format

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[howie [:howie]]

There will be a setting toggle to let user choose between 12/24 hour time format in v2.1. User story and settings spec: Bug 903683

For each app, the tasks to do after toggle is added would be:
1.Read/listen to the time format toggle value/change event.

2.Input the corresponding time format to existing mozL10n.DateTimeFormat() function. Currently the input time format should be a fixed 12 hour 
shortTimeFormat = %I:%M %p , line 201 of http://goo.gl/DR4CNe. There will be a 24 hour time format added.

3.Show the return of the function as it's doing now.

Comment 1

[howie [:howie]]

Hi Daniel, there is 12/24 hour time format work for cost control in FX OS 2.1. Will you be able to take this? Thank you!

Comment 2

[howie [:howie]]

Hi Maria, have you found developer for this? The work may start after dependent bug 1023735 is fixed, around Aug 18th. Thank you!

Comment 3

[Maria Angeles Oteo (:oteo)]

Sure, Salva can work in it as Marina in in PTO until end of August.
Salva, can you assign the bug to yourself? thanks a lot!

Comment 4

[Salvador de la Puente González [:salva]]

Sure! Assigning to me!

Comment 5

[[e-mail]]

Test steps:

1. Open settings app
2. change the Time format settings in Settings > Date & Time > Time Format panel

Expect:

The time format in cost control app will be changed.


here's the patch steps to apply correct time format:

1. include navigator.mozHour12 API shim in gaia app's html

```
<script defer src="shared/js/date_time_helper.js"></script>
```

(currently we still need at least `settings: readonly` permission in manifest, which might changed in next release)


2. detect proper time format via mozHour12 API, and get correct time format string from new 'shortTimeFormat12'/'shortTimeFormat24'.

```
var timeFormat = window.navigator.mozHour12 ? _('shortTimeFormat12') : _('shortTimeFormat24');
```

3. call mozL10n DateTimeFormat to localize it


4. listen to 'timeformatchange' event and localize time strings when its triggered


The full usage is at [3](WIP) for reference.


[3] https://github.com/mozilla-b2g/gaia/pull/22757/files

Comment 6

[howie [:howie]]

Hi Salva, the Settings app work is done and you may start the bug now :)

The detail is in Comment 5, feel free to let us know if there's any question, thank you!

Comment 7

[Salvador de la Puente González [:salva]]

Sorry for the delay :howie but I was attending bug 1043662 which is 2.0+

I'm working on this one right now.

Comment 8

[Salvador de la Puente González [:salva]]

Attachment: Add support for 24h / 12h time format changes.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8475816 [details] [review]
Add support for 24h / 12h time format changes.

Excellent job here.

Just left a super tiny comment, but apart from that r+

Comment 10

[Salvador de la Puente González [:salva]]

master: e410e931c53bf4d67b09e90bc4e57baadc580a8e

Comment 11

[howie [:howie]]

Thanks everyone!

Comment 12

[Loli (:lolimartinezcr)]

Tested and working but it * isn't verified * because we need to test hour time format in balance with a prepaid SIM card with coverage.

Flame
2.1
Gecko-2fbbb04
Gaia-59bd661

Comment 13

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Cost control properly updates its time based on the format specified in settings with both Postpaid, and Prepaid SIM cards. However, I am unable to verify this bug until the depends on bug is verified first (bug 1023735)

Comment 14

[Shine(Leave from Mozilla)]

Attachment: screenshot

This issue has been verified successfully on Flame 2.1
See attachment: Flame2.1_screenshot.png
Reproducing rate: 0/3
Reproducing steps:
1. Open settings app
2. Date & Time > Time Format
** The 24-hour time format has been added.

Flame 2.1 build:
Gaia-Rev        dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID        20141203001205
Version         34.0