1035811 - Mochitest manifest warnings dumped at start of each robocop test

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Geoff Brown [:gbrown]]

Mochitest manifest warnings now appear at the start of each Robocop test:

https://tbpl.mozilla.org/php/getParsedLog.php?id=43246078&tree=Mozilla-Inbound&full=1

06:20:28     INFO -  Warning: test_XHR_timeout.js from manifest /builds/slave/test/build/tests/mochitest/tests/content/base/test/mochitest.ini is not a valid test
06:20:28     INFO -  Warning: test_bug357450.js from manifest /builds/slave/test/build/tests/mochitest/tests/content/base/test/mochitest.ini is not a valid test
06:20:28     INFO -  Warning: test_bug380418.html^headers^ from manifest /builds/slave/test/build/tests/mochitest/tests/content/base/test/mochitest.ini is not a valid test
06:20:28     INFO -  Warning: test_bug402150.html^headers^ from manifest /builds/slave/test/build/tests/mochitest/tests/content/base/test/mochitest.ini is not a valid test
06:20:28     INFO -  Warning: test_bug493881.js from manifest /builds/slave/test/build/tests/mochitest/tests/content/base/test/mochitest.ini is not a valid test
...

These warnings seem irrelevant to Robocop tests. They did not appear prior to landing the patch for bug 1014125:

https://tbpl.mozilla.org/php/getParsedLog.php?id=43245296&tree=Mozilla-Inbound&full=1

Comment 1

[Geoff Brown [:gbrown]]

Also, Robocop logs seem to no longer dump logcat following a failure / crash:

https://tbpl.mozilla.org/php/getParsedLog.php?id=43357167&full=1&branch=mozilla-inbound#error0

Comment 2

[Vaibhav (:vaibhav1994)]

Attachment: warning.patch

Try push: https://tbpl.mozilla.org/?tree=Try&rev=c36895734f65

Now the "warning:" comments are not being dumped.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8456125 [details] [diff] [review]
warning.patch

Review of attachment 8456125 [details] [diff] [review]:
-----------------------------------------------------------------

great stuff here!  Have you sanity checked that this doesn't mess up b2g or desktop?  The try run for android looks great.

Comment 4

[Vaibhav (:vaibhav1994)]

Attachment: warning.patch

Try Push: https://tbpl.mozilla.org/?tree=Try&rev=02872ecd740c

Comment 5

[Vaibhav (:vaibhav1994)]

:gbrown, I would like your review for this patch. In this patch, I have added a method "getTestsToRun" which is also in runtests.py: http://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtests.py#1380 . Now the reason we require this is because we don't want to filter the manifest in case of robocopIni tests (something similar to buildTestPath method in runtestsremote.py). After discussing with :jmaher, I had another thought, we are working to remove the "Warning:" log here: http://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtests.py#1363 , and in that case we won't need this extra method. I would like to know which way do you prefer?

Comment 6

[Geoff Brown [:gbrown]]

Comment on attachment 8456676 [details] [diff] [review]
warning.patch

Review of attachment 8456676 [details] [diff] [review]:
-----------------------------------------------------------------

I like it this way -- better to skip all of that for Robocop since it is not needed.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cac86ecd534e

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cac86ecd534e