Mochitest manifest warnings dumped at start of each robocop test

RESOLVED FIXED in mozilla33

Status

Testing
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gbrown, Assigned: vaibhav1994)

Tracking

Trunk
mozilla33
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Mochitest manifest warnings now appear at the start of each Robocop test:

https://tbpl.mozilla.org/php/getParsedLog.php?id=43246078&tree=Mozilla-Inbound&full=1

06:20:28     INFO -  Warning: test_XHR_timeout.js from manifest /builds/slave/test/build/tests/mochitest/tests/content/base/test/mochitest.ini is not a valid test
06:20:28     INFO -  Warning: test_bug357450.js from manifest /builds/slave/test/build/tests/mochitest/tests/content/base/test/mochitest.ini is not a valid test
06:20:28     INFO -  Warning: test_bug380418.html^headers^ from manifest /builds/slave/test/build/tests/mochitest/tests/content/base/test/mochitest.ini is not a valid test
06:20:28     INFO -  Warning: test_bug402150.html^headers^ from manifest /builds/slave/test/build/tests/mochitest/tests/content/base/test/mochitest.ini is not a valid test
06:20:28     INFO -  Warning: test_bug493881.js from manifest /builds/slave/test/build/tests/mochitest/tests/content/base/test/mochitest.ini is not a valid test
...

These warnings seem irrelevant to Robocop tests. They did not appear prior to landing the patch for bug 1014125:

https://tbpl.mozilla.org/php/getParsedLog.php?id=43245296&tree=Mozilla-Inbound&full=1
(Reporter)

Comment 1

3 years ago
Also, Robocop logs seem to no longer dump logcat following a failure / crash:

https://tbpl.mozilla.org/php/getParsedLog.php?id=43357167&full=1&branch=mozilla-inbound#error0
(Assignee)

Updated

3 years ago
Assignee: nobody → vaibhavmagarwal
(Assignee)

Comment 2

3 years ago
Created attachment 8456125 [details] [diff] [review]
warning.patch

Try push: https://tbpl.mozilla.org/?tree=Try&rev=c36895734f65

Now the "warning:" comments are not being dumped.
Attachment #8456125 - Flags: review?(jmaher)
Comment on attachment 8456125 [details] [diff] [review]
warning.patch

Review of attachment 8456125 [details] [diff] [review]:
-----------------------------------------------------------------

great stuff here!  Have you sanity checked that this doesn't mess up b2g or desktop?  The try run for android looks great.
Attachment #8456125 - Flags: review?(jmaher) → review+
(Assignee)

Comment 4

3 years ago
Created attachment 8456676 [details] [diff] [review]
warning.patch

Try Push: https://tbpl.mozilla.org/?tree=Try&rev=02872ecd740c
Attachment #8456125 - Attachment is obsolete: true
(Assignee)

Comment 5

3 years ago
:gbrown, I would like your review for this patch. In this patch, I have added a method "getTestsToRun" which is also in runtests.py: http://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtests.py#1380 . Now the reason we require this is because we don't want to filter the manifest in case of robocopIni tests (something similar to buildTestPath method in runtestsremote.py). After discussing with :jmaher, I had another thought, we are working to remove the "Warning:" log here: http://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtests.py#1363 , and in that case we won't need this extra method. I would like to know which way do you prefer?
Flags: needinfo?(gbrown)
(Assignee)

Updated

3 years ago
Attachment #8456676 - Flags: review?(gbrown)
(Reporter)

Comment 6

3 years ago
Comment on attachment 8456676 [details] [diff] [review]
warning.patch

Review of attachment 8456676 [details] [diff] [review]:
-----------------------------------------------------------------

I like it this way -- better to skip all of that for Robocop since it is not needed.
Attachment #8456676 - Flags: review?(gbrown) → review+
(Reporter)

Updated

3 years ago
Flags: needinfo?(gbrown)
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/cac86ecd534e
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cac86ecd534e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.