1035846 - ToS notice in Loop popup window points to wrong URL

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Romain Testard [:RT]]

The current ToS notice points to https://accounts.firefox.com/en-us/legal/terms
The Loop ToS are on https://github.com/mozilla/legal-docs/blob/master/WebRTC_ToS/en-US.md

ALthough we're awaiting confirmation about the URL to use.

This bug is to track:
* Confirmation of URL pointing to Loop ToS
* Implementation on the Loop desktop client

Comment 1

[Romain Testard [:RT]]

Shell please confirm the URL when you get the info.

Comment 2

[Geoff Piper]

What is the status of the TOS URL? Has it been implemented? It is hard to know from the actions/comments in this bug and just following up to make sure we get this done asap.

Comment 3

[Alexis Metaireau (:alexis)]

Geoff, this is to be handled in bug 1044411. We need to know where we should host this still.

Comment 5

[Maire Reavy [:mreavy]]

Alexis -- Do you need any client work on this bug, or can I close this as a dup of bug 1044411 if that's where all the work for this is being done?

Comment 6

[Alexis Metaireau (:alexis)]

We don't know where this will be stored yet. bug 1044411 is the one where this decision will be done, and then client needs to be updated with this url after that.

Comment 7

[Maire Reavy [:mreavy]]

Alexis -- So, all the work will be done on bug 1044411 and then this bug is just for updating the URL.  Am I correct?

Comment 8

[Alexis Metaireau (:alexis)]

This is correct, yes.

Comment 10

[:shell escalante]

Arcadio approved URL, so confirming this is unblocked to use https://hello.firefox.com/legal/terms as the ToS URL.

Comment 11

[Maire Reavy [:mreavy]]

Adam is handling this over on bug 1044411

Comment 12

[Mark Banner (:standard8)]

Attachment: Update the ToS link for the Loop standalone UI.

Now bug 1044411 has landed, this updates the ToS link for the standlone client. I'm proposing we change the desktop one separately, once bug 1044411 has been pushed to production.

Comment 13

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8490763 [details] [diff] [review]
Update the ToS link for the Loop standalone UI.

Review of attachment 8490763 [details] [diff] [review]:
-----------------------------------------------------------------

r=dmose

Comment 14

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/711a0c039ced

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/711a0c039ced

Comment 16

[Maire Reavy [:mreavy]]

Mark -- can we mark this as resolved now?

Comment 17

[Mark Banner (:standard8)]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #16)
> Mark -- can we mark this as resolved now?

No, we need to desktop once production is live.

Comment 18

[Mark Banner (:standard8)]

I had to push a follow-up fix so that the standalone client works correctly with the ToS on the staging server:

https://hg.mozilla.org/integration/fx-team/rev/56e6f150cd6c

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/56e6f150cd6c

Comment 20

[Mark Banner (:standard8)]

Attachment: Update the ToS link for the Loop panel.

Now we've got the page live, here's the link change for the panel.

Comment 21

[Adam Roach [:abr]]

Comment on attachment 8495351 [details] [diff] [review]
Update the ToS link for the Loop panel.

Review of attachment 8495351 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 22

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/c6355e364936

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c6355e364936

Comment 24

[u279076]

I'm untracking this for verification. This will be covered through smoketesting.

Comment 25

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8490763 [details] [diff] [review]
Update the ToS link for the Loop standalone UI.

Approval Request Comment
Uplift request for patches staged and tested on Fig

Comment 26

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1c47b01eea85
https://hg.mozilla.org/releases/mozilla-aurora/rev/ba71cd5336b1

Comment 27

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8490763 [details] [diff] [review]
Update the ToS link for the Loop standalone UI.

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.

Comment 28

[u279076]

We have a Moztrap smokestest for ToS/Privacy in the Hello panel and Standalone page.