Closed
Bug 1035966
Opened 11 years ago
Closed 9 years ago
Add Deleter::Pointer support to UniquePtr
Categories
(Core :: MFBT, enhancement)
Core
MFBT
Tracking
()
RESOLVED
DUPLICATE
of bug 1255857
People
(Reporter: Waldo, Unassigned)
References
Details
Attachments
(1 file)
|
2.29 KB,
patch
|
Details | Diff | Splinter Review |
mozilla::UniquePtr landed without support for Deleter::Pointer, in the interests of not letting the perfect be the enemy of good. We should finish this up at some point.
It'd be easiest to do this after we drop gcc < 4.6, because then we have true nullptr and don't have to do crazy template overloading hacks, but it might be possible to do before then. (My initial abortive attempt happened to be for a file handle smart pointer, where the handle is an int. That very quickly ran into not-true-nullptr issues. It's possible if the resource type isn't int/long, that these problems don't manifest.) I'm not working on this *at least* until true nullptr, but anyone else with a willingness to work through compiler sadness should feel free.
|
Reporter | |
Comment 1•11 years ago
|
||
|
||
Comment 2•9 years ago
|
||
I *think* this is now a dupe of Bug 1255857.
If not, feel free to re-open.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•