1036044 - Convert Applications pane dialogs to be in-content

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Richard Marti (:Paenglab)]

Convert applications.js to use gSubDialog.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: applicationsDialogsIncontent.patch

For applicationManager.xul I leaved the "resizable=no" in view of bug 1035625. If you don't want this, I can use null.

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8453328 [details] [diff] [review]
applicationsDialogsIncontent.patch

Review of attachment 8453328 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Richard!

Comment 3

[Matthew N. [:MattN]]

(In reply to Richard Marti (:Paenglab) from comment #1)
> For applicationManager.xul I leaved the "resizable=no" in view of bug
> 1035625.

I think it's the right thing to keep non-resizable dialogs as such by default.

Comment 4

[Richard Marti (:Paenglab)]

Try: https://tbpl.mozilla.org/?tree=Try&rev=8391c7f5d14d

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/e0eafaf33b21

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e0eafaf33b21

Comment 7

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.8.5 using latest Nightly 34.0a1 (buildID: 20140728030201) and the following mention should be done: 
- on Mac and Ubuntu: if I select "Use other..." option, the "Select Helper Application" dialog is not in-content (on Windows, this dialog is in-content). 

Is this the behaviour intended?

Comment 8

[Richard Marti (:Paenglab)]

I have now no access to a Mac or Linux, but I remember also the normal dialog prefs on them is using a system dialog and not a FX specific dialog like on Windows. See also the #ifdef: http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/in-content/applications.js#1741

So I would say this is intended.