Closed Bug 1036044 Opened 6 years ago Closed 6 years ago

Convert Applications pane dialogs to be in-content

Categories

(Firefox :: Preferences, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 33

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file)

Convert applications.js to use gSubDialog.
For applicationManager.xul I leaved the "resizable=no" in view of bug 1035625. If you don't want this, I can use null.
Attachment #8453328 - Flags: review?(MattN+bmo)
Comment on attachment 8453328 [details] [diff] [review]
applicationsDialogsIncontent.patch

Review of attachment 8453328 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Richard!
Attachment #8453328 - Flags: review?(MattN+bmo) → review+
(In reply to Richard Marti (:Paenglab) from comment #1)
> For applicationManager.xul I leaved the "resizable=no" in view of bug
> 1035625.

I think it's the right thing to keep non-resizable dialogs as such by default.
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e0eafaf33b21
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Verified on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.8.5 using latest Nightly 34.0a1 (buildID: 20140728030201) and the following mention should be done: 
- on Mac and Ubuntu: if I select "Use other..." option, the "Select Helper Application" dialog is not in-content (on Windows, this dialog is in-content). 

Is this the behaviour intended?
Flags: needinfo?(richard.marti)
I have now no access to a Mac or Linux, but I remember also the normal dialog prefs on them is using a system dialog and not a FX specific dialog like on Windows. See also the #ifdef: http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/in-content/applications.js#1741

So I would say this is intended.
Flags: needinfo?(richard.marti)
Status: RESOLVED → VERIFIED
Depends on: 1111540
You need to log in before you can comment on or make changes to this bug.