Improve .csv export for events data

RESOLVED FIXED

Status

Webmaker
Events
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: OpenMatt, Assigned: gvn)

Tracking

Details

(Whiteboard: [events] [july25])

Attachments

(3 attachments)

* This .csv data is important for key tracking and metrics. Improving the quality of the data coming out is important for the weekly reports Amira is expected to provide. 

Two issues:

1) "country" and "city" fields are often exporting as "null." These are key pieces of data we need. 


2) garbled formatting
* For example, the "number of attendees" field occasionally displays the event address instead
* Entire sections of the file break format and display the wrong data. Here's a screen grab: 
https://www.dropbox.com/s/mv70s1lt7n5wvn6/Screen%20Shot%202014-07-08%20at%204.24.19%20PM.png
(Reporter)

Comment 1

4 years ago
* gvn: not sure who else to assign this to, so assigning to you for now -- please reassign as needed
Assignee: nobody → gavin
Whiteboard: [events] [july11]
(Assignee)

Comment 2

4 years ago
I'll see what I can do!

1. Unfortunately we can't guarantee these won't be null. It's up to the organizer to provide a location that country and city can be parsed from. Google's location API does the parsing. If a full address isn't provided it may not find a country or city (eg: "123 Fake Street" doesn't have a country or city).

2. I'm looking into this. I think I've got some ideas on improving it. Commas and line breaks in descriptions may be throwing things off.
(Assignee)

Comment 3

4 years ago
Created attachment 8453423 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/57
Attachment #8453423 - Flags: review?(cade)
(Reporter)

Comment 4

4 years ago
Thanks Gavin! I think (2) was the main pain-point, so progress on that will be awesome
Whiteboard: [events] [july11] → [events] [july25]

Updated

4 years ago
Attachment #8453423 - Flags: review?(cade) → review+
(Assignee)

Comment 5

4 years ago
Created attachment 8455561 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/62

This should be event better...
Attachment #8455561 - Flags: review?(cade)
(Assignee)

Comment 6

4 years ago
-t
Comment on attachment 8455561 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/62

This works, but it does kinda break down on array values like mentors and coorganizers. 

Is that going to be an issue? R+ if not.
Attachment #8455561 - Flags: review?(cade) → review+
(Reporter)

Comment 8

4 years ago
+ Hannah

* Thanks Cade! 

* This is actually quite an important bug to get right -- many customers needs this CSV data in a better form than they're currently getting.
Flags: needinfo?(gavin)
(Assignee)

Comment 9

4 years ago
I think the way it represents arrays is OK. It still shows their contents, just adds brackets around them too for some reason. I'm going to go ahead and merge and if anyone has problems with it we can revisit, but it should be a huge improvement.
Flags: needinfo?(gavin)
Lets land and build, and see if this works for the party makers.
(Assignee)

Comment 11

4 years ago
Landed, not yet deployed.
(Assignee)

Comment 12

4 years ago
Created attachment 8456372 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/67

Actually you were right, Cade. The sub-objects for mentors/coorgs were rendering super badly. This should clean that up...
Attachment #8456372 - Flags: review?(cade)
Comment on attachment 8456372 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/67

yes, this is soooo much better.

I did leave one suggestion in the pull request, but I leave it up to you whether or not it's worthwile, since it's just a cosmetic change to the code.
Attachment #8456372 - Flags: review?(cade) → review+
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Updated

4 years ago
Blocks: 1039557
(Reporter)

Comment 14

4 years ago
An-Me reports: 

'the data in the date column is "null"'


Thoughts?
Status: RESOLVED → REOPENED
Flags: needinfo?(gavin)
Resolution: FIXED → ---

Comment 15

4 years ago
Worked for me, though many of the date fields were null, especially those at the top of the list. When I scrolled down, I saw most of the date fields had valid data. I removed the line items with null in the date fields because, as I understood it, they're null for legacy reasons and are therefore old events anyway. 

I added that note to https://wiki.mozilla.org/Webmaker/Events_export
(Assignee)

Comment 16

4 years ago
That's correct, many legacy events won't have dates attached to them. Thanks for adding that to the wiki!
Flags: needinfo?(gavin)
(Assignee)

Comment 17

4 years ago
Going ahead and re-closing this one. Feel free to re-open if there are other issues.
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.