1036174 - MSISDN-Gateway 'make test' consistently fails on RHEL Linux builds

Status: VERIFIED FIXED

(Cloud Services Graveyard :: MobileID, defect)

Description

[James Bonacci [:jbonacci]]

I git cloned and built msisdn-gateway on RHEL 6.4 and 6.5.
Then I did this:
$ cd loadtests
$ make build
I did not see any specific, unexpected errors during the build process.

But, when I run 'make test', I always get the same error:
make test
OMXEN_URL=http://omxen.dev.mozaws.net ./venv/bin/loads-runner --config=./config/test.ini --server-url=https://msisdn.stage.mozaws.net loadtest.TestMSISDN.test_all
USING http://omxen.dev.mozaws.net OMXEN endpoint
[===================================================================] 100%
Duration: 0.76 seconds
Hits: 4
Started: 2014-07-08 23:46:33.492240
Approximate Average RPS: 5
Average request time: 0.17s
Opened web sockets: 0
Bytes received via web sockets : 0

Success: 0
Errors: 1
Failures: 0

1 occurrences of: 
    AttributeError: 'TestMSISDN' object has no attribute 'assertIsInstance'    Traceback: 
  File "/usr/lib64/python2.6/unittest.py", line 278, in run
    testMethod()
  File "loadtest.py", line 50, in test_all
    message = self.read_message()
  File "loadtest.py", line 139, in read_message
    self.assertIsInstance(messages, list,


Slowest URL: https://msisdn.stage.mozaws.net/discover 	Average Request Time: 0.421562

Stats by URLs:
- https://msisdn.stage.mozaws.net/discover
Average request time: 0.421562	Hits success rate: 1.0

- http://54.90.7.164:80/receive?to=BLAH
Average request time: 0.12837	Hits success rate: 1.0

- https://msisdn.stage.mozaws.net/sms/momt/nexmo_callback?msisdn=BLAH
Average request time: 0.073583	Hits success rate: 1.0

- https://msisdn.stage.mozaws.net/register
Average request time: 0.064608	Hits success rate: 1.0

Custom metrics:
- register : 1
- momt-flow : 1
make: *** [test] Error 1


I do not see this error on Mac or Ubuntu.

Comment 1

[Tarek Ziadé (:tarek)]

This is happening because assertIsInstance is a Python 2.7 feature. We'll make it 2.7 compatible

Comment 2

[Rémy Hubscher (:natim)]

Good catch, I think we shouldn't support Python 2.6 anymore but if it is just about loadtests we may find another way to test it.

Comment 3

[Rémy Hubscher (:natim)]

https://github.com/mozilla-services/msisdn-gateway/commit/993a167b163b2bae1dadec1377b432c7ed668d2f

Comment 4

[James Bonacci [:jbonacci]]

This will have to wait.
I am blocked on bug 1036158

Comment 5

[James Bonacci [:jbonacci]]

OK, no, not blocked on bug 1036158.
That is for unit tests not make test...

Comment 6

[James Bonacci [:jbonacci]]

Awesome. Verified as fixed on RHEL 6.4, RHEL 6.5.
Verified as still working on Mac and Ubuntu 14.04.