1036210 - Can't connect to network if switching to auto selection toggle while manual selection is still in progress

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Chris]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36

Steps to reproduce:

Camp a phone on a live network.

1)Settings->Cellular & Data -> Network operator -> Disable Automatic Network Selection

2)Wait for list of available networks

3) Select an available network that is not camped


Actual results:

While the manual network selection is in progress, a user is able to touch the UI and re-able automatic network selection and the list of available manual networks ( and their respective status ) disappears.


Expected results:

While the manual network selection is in progress, all ui elements should be disabled or paused until the manual selection completes.

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

You may want to take this?

Comment 2

[Dietrich Ayala (:dietrich)]

[Blocking Requested - why for this release]:

Howie, this is a great addition but is more of a new feature than a blocking bug.

Can you explain why this bug is so important we should block the release on it? For reference, here is the criteria used to determine what does/doesn't block a release: https://wiki.mozilla.org/B2G/Triage#Blocker_Triage_Guidelines

Thanks!

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Gecko does not support switching to automatic selection while there is still pending manual selections. In this case, after the STR the device cannot connect to network automatically until users switch back to manual selection and select the available networks, which is annoying. Disabling the checkbox is one of the solution helps avoid this problem.

Jenny, does the UI change make sense to you?

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

The other way would be not disabling the checkbox, but re-trigger the automatic connection after the manual selection finishes.

Comment 5

[Jenny Lee]

(In reply to Arthur Chen [:arthurcc] from comment #4)
> The other way would be not disabling the checkbox, but re-trigger the
> automatic connection after the manual selection finishes.

Hi Arthur, per discussion, let's go with this solution, thank you!

Comment 6

[howie [:howie]]

(In reply to Dietrich Ayala (:dietrich) from comment #2)
> [Blocking Requested - why for this release]:
> 
> Howie, this is a great addition but is more of a new feature than a blocking
> bug.
> 
> Can you explain why this bug is so important we should block the release on
> it? For reference, here is the criteria used to determine what does/doesn't
> block a release:
> https://wiki.mozilla.org/B2G/Triage#Blocker_Triage_Guidelines
> 
> Thanks!

Sorry didn't make it clear. Arthur just added more information. This is a blocker because it's solving the issue on Comment 3.

Comment 7

[Anshul]

(In reply to Jenny Lee from comment #5)
> (In reply to Arthur Chen [:arthurcc] from comment #4)
> > The other way would be not disabling the checkbox, but re-trigger the
> > automatic connection after the manual selection finishes.
> 
> Hi Arthur, per discussion, let's go with this solution, thank you!
This doesn't seem inline with how other settings like APM behave, which is disabled when the operation is in progress and so are settings like call forwarding. Please explain why this seems like a better solution than disabling the checkbox?

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

On my device it takes around 25 secs trying to connect to an operator, thus disabling the checkbox for this long time seems frustrating when users change their mind and turn back to use automatic selection.

Comment 9

[Jason Smith [:jsmith]]

QA Wanted to branch check.

Comment 10

[Adam Alldredge [:AdamA][Inactive]]

This issue reproduces in 2.2 Flame, 2.2 Open_C, 2.1 Flame, 2.0 Flame, and 1.4 Flame.

Device: Flame 2.2 Master
BuildID: 20140912061053
Gaia: b72909030e214175144342f7e5df7e88a2b52fd4
Gecko: 59d4326311e0
Version: 35.0a1 (2.2 Master)
Firmware: V165
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Open_C 2.2 Master
BuildID: 20140912061053
Gaia: b72909030e214175144342f7e5df7e88a2b52fd4
Gecko: 59d4326311e0
Version: 35.0a1 (2.2 Master)
Firmware: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Flame 2.1
BuildID: 20140912023307
Gaia: ee335e6340dab596239d335bb571b732775dc84e
Gecko: 48c37c8442cb
Version: 34.0a2 (2.1)
Firmware: V165
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Device: Flame 2.0
BuildID: 20140911220254
Gaia: 91dd0e596aa7c124dd968e1474b23e7992dc35a1
Gecko: a66168598533
Version: 32.0 (2.0)
Firmware: V165
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Device: Flame 1.4 (Base)
BuildID: 20140814202332
Firmware: v165
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Result:
The phone does not connect to a network when automatic selection is enabled while it is connecting to a network manually.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

What's the action item here?

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

This will be my next item to do after clearing the review queue.

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/24681

As this is a 2.1 blocker so I was trying to make a minimum change as possible as I can. What we are doing in the patch was basically recovering the automatic selection of operators after the manual selection completes. Let me know if you need any help when reviewing the patch, thanks!

Comment 14

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8498765 [details]
link to https://github.com/mozilla-b2g/gaia/pull/24681

It works well, so r+ ! Thanks Arthur :)

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8498765 [details]
link to https://github.com/mozilla-b2g/gaia/pull/24681

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): N/A
[User impact] if declined: Users have to wait for a long time before they are able to set the settings back to automatic connection.
[Testing completed]: Manual tests are completed
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: N/A

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8498765 [details]
link to https://github.com/mozilla-b2g/gaia/pull/24681

Cancel the approval request as the patch does not land to master yet.

Comment 17

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: fe123d3380ee635886870ddbd4f6e6c91e4d6f73

Comment 18

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8498765 [details]
link to https://github.com/mozilla-b2g/gaia/pull/24681

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): N/A
[User impact] if declined: Users have to wait for a long time before they are able to set the settings back to automatic connection.
[Testing completed]: Manual tests are completed
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: N/A

Comment 19

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: PR against v2.1

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/18917f59141b850280c68e551e80dea41e4ac498

Comment 22

[sarsenyev]

The issue is fixed on 2.2 and 2.1

The device switches back to "Automatic" and connected to network

"Flame 2.2

Device: Flame 2.2 (319mb)(Kitkat Base)(Shallow Flash)
Build ID: 20141117040203
Gaia: ddf5b92f43ec27c93ad4fea4fd1207da8936b8e7
Gecko: 21b745197618
Version: 36.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0"

"Flame 2.1 

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141117001201
Gaia: 81160ad79e5b4c21967418dd63f1a1d08d77924e
Gecko: 3572aa3e6766
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0"