103622 - show view-source in a tab, not a separate window

Status: RESOLVED DUPLICATE of bug 1067325

(Toolkit :: View Source, enhancement)

Description

[Jo Hermans]

Can't we have an option where a view-source is shown in a tab, and not in a
separate window instead ? This is not only faster, but it's identical to the
behaviour of the composer window.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is certainly doable.  Note, however, that the view source window and the
browser window have different menus and options available.  There may well be
options that are available in the view source window but not in a tab (eg the
proposed "save highlighted source" option).

Comment 2

[Doron Rosenberg (IBM)]

we need to first fix the tab bugs, not add new features :)

Comment 3

[sairuh (rarely reading bugmail)]

spam: set your filter for "SeverusSnape" to avoid the influx of bugmail

changing QA contact of open tabbed browser bugs from blake to me. if this bug
requires a reassignment, however, feel free to change it!

Comment 4

[Jeremy M. Dolan]

This would be very cool, for the most part.

> Note, however, that the view source window and the browser window
> have different menus and options available.

Hrm... that is a problem. View source menu already has 'wrap long lines'.

How about add the menu inside the tab? (Like when you load
chrome://navigator/content/navigator.xul). A little wierd, but another menu bar
doesn't waste that much space, and as enabling tab browsing, then enabling show
source in tab, then viewing source is a very advanced user thing, it should be
acceptable.

Comment 5

[David Hyatt]

Reassigning to new component owner.

Comment 6

[jag (Peter Annema)]

-> future, helpwanted

Comment 7

[Robert Wall]

*** Bug 143218 has been marked as a duplicate of this bug. ***

Comment 8

[Frank Widmaier]

@Jo Hermans: workaround

you should use "multizilla" (http://multizilla.mozdev.org/). with that it's
possible to show the sourcecode in a tab

Comment 9

[timeless]

as long as you just want to see marked up source and not live dom, you can do this:

prefix view-source: to the current url in the urlbar
eg: view-source:http://bugzilla.mozilla.org/show_bug.cgi?id=103622
select the complete url (you can focus outside the urlbar and then click the url
or proxy)
drag the selected text (url) to a tab, or to blank tabbar space, or the new tab
icon, or the close tab icon - whoops :-)

Comment 10

[Jo Hermans]

*** Bug 190937 has been marked as a duplicate of this bug. ***

Comment 11

[Bill Mason]

*** Bug 265823 has been marked as a duplicate of this bug. ***

Comment 12

[Alex Vincent [:WeirdAl]]

*** Bug 276805 has been marked as a duplicate of this bug. ***

Comment 13

[Erik Fabert]

*** Bug 279614 has been marked as a duplicate of this bug. ***

Comment 14

[Jo Hermans]

*** Bug 284435 has been marked as a duplicate of this bug. ***

Comment 15

[Aaron Slunt]

Is it alright to load the menu in the new tab? (I think it looks kinda cool...)

If so, I can have a patch for this.

Comment 16

[Jo Hermans]

I know that I reported this bug, but now I think it can't be done. The reason is
that a different menu has to be shown for this tab only, and that's not
possible. Merging the 2 menubars is ok (enabling/diabling the menuitems based on
the tab that has the focus).

But displaying a menubar inside a taab ? No way ! I would rather vote against my
own bug, if that would be possible. There's only 1 menubar, that that is at the
top of the menu or the screen (I'm a Mac-user, so ...).

Comment 17

[Aaron Slunt]

Attachment: screenshot of view source xul in tab

It doesn't look bad at all to me.

Comment 18

[Magnus Melin [:mkmelin]]

Well, there are only two additional menu items for view-source, the "wrap long
lines" and the "syntax highlighling". So having the whole menu with File, Edit
etc. seems redundant. But something with just those two options could be nice. 

Comment 19

[Jo Hermans]

(In reply to comment #18)
> Well, there are only two additional menu items for view-source, the "wrap long
> lines" and the "syntax highlighling". So having the whole menu with File, Edit
> etc. seems redundant. But something with just those two options could be nice. 

A real menu always has File & Edit, even if every item is disabled.

The whole issue is about 2 extra menu-items vor the View menu. There's no need
to rape GUI-guidelines for this, just move them in the exisiting menu. That is,
is we're still going to implement something like this. I'm not convinced anymore.

Comment 20

[Magnus Melin [:mkmelin]]

Maybe just a bar with just the two items as checkboxes? I agree a menu wouldn't
be very nice. 

But on the other hand, wouldn't it be possible to hide these 2 items deep in the
options somewhere. Would someone object? Firefox has pretty trimmed menus as it
is, is this really something that prominent? I can't even think of a case were
someone would acually want to turn of syntax highlighting. Line wrap on the
other hand... What about just putting it in the context meny of view-souce pages?

Comment 21

[Eric L]

"Edit->Go to line..." is also unique to the view source window.

Personally, I think having a bar across the top of the tab with these three
extra things (but not a full menu bar) would be fine.  I'm imagining it as sort
of like the find bar, except permanent in that tab.  

Comment 22

[Jon B]

(In reply to comment #21)
> "Edit->Go to line..." is also unique to the view source window.
> 
> Personally, I think having a bar across the top of the tab with these three
> extra things (but not a full menu bar) would be fine.  I'm imagining it as sort
> of like the find bar, except permanent in that tab.  

The same style of bar across the top that is used when blocking popups and XPI
downloads is fine.  Or just put the extra options in the context menu.

Comment 23

[Jo Hermans]

http://brian.kingsonline.net/talk/index.php/archives/119

There's now a "View Source Choice" extension available for Firefox 1.5, that offers this possibility.

Comment 24

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

This feature landed in bug 1067325.