1036220 - Get rid of dom.mozAlarms.enabled pref

Status: RESOLVED WONTFIX

(Core :: DOM: Device Interfaces, defect)

Description

[Reuben Morais [:reuben]]

Shouldn't be needed since the interface also has [CheckPermissions]. This means we can include mozAlarms in the Navigator.getFeature list (bug 1009645).

Comment 1

[Reuben Morais [:reuben]]

Attachment: Get rid of the dom.mozAlarms.enabled pref

Comment 2

[(no longer active)]

Nice!

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8452849 [details] [diff] [review]
Get rid of the dom.mozAlarms.enabled pref

Review of attachment 8452849 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comments addressed.

::: dom/alarm/test/test_alarm_non_permitted_app.html
@@ +13,4 @@
>  
>  "use strict";
>  
>  SimpleTest.waitForExplicitFinish();

Do we need async tests here?

@@ -18,5 @@
>    SpecialPowers.removePermission("alarms", document);
>    window.location.reload();
>  } else {
> -  SpecialPowers.pushPrefEnv({"set": [["dom.mozAlarms.enabled", true]]}, function() {
> -    SpecialPowers.removePermission("alarms", document);

This removePermission() should be preserved.

::: dom/alarm/test/test_alarm_permitted_app.html
@@ +12,5 @@
>  <script type="application/javascript">
>  
>  "use strict";
>  
>  SimpleTest.waitForExplicitFinish();

Do we need async tests here?

::: dom/tests/mochitest/general/test_interfaces.html
@@ -112,5 @@
>  // IMPORTANT: Do not change the list below without review from a DOM peer!
>  var interfaceNamesInGlobalScope =
>    [
>  // IMPORTANT: Do not change this list without review from a DOM peer!
> -    {name: "AlarmsManager", pref: "dom.mozAlarms.enabled"},

Ask a DOM peer?

Comment 4

[Reuben Morais [:reuben]]

Attachment: Get rid of the dom.mozAlarms.enabled pref

Comments addressed, carrying r=nsm.

Comment 5

[Reuben Morais [:reuben]]

Olli, the alarm parts are reviewed, I need a DOM peer review for the test_interfaces change.

Comment 6

[Reuben Morais [:reuben]]

https://hg.mozilla.org/integration/b2g-inbound/rev/4f82325c577f

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for breaking Android mochitests: https://tbpl.mozilla.org/php/getParsedLog.php?id=43856034&tree=B2g-Inbound

https://hg.mozilla.org/integration/b2g-inbound/rev/da1b857571c2

Comment 8

[Reuben Morais [:reuben]]

DOM Alarms no longer exists.