Do not use __asan_default_options with clang-cl because it is not supported yet

RESOLVED FIXED in mozilla33

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

(Blocks: 1 bug)

unspecified
mozilla33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8452837 [details] [diff] [review]
Do not use __asan_default_options with clang-cl because it is not supported yet
(Assignee)

Updated

4 years ago
Assignee: nobody → ehsan
Blocks: 1030826
(Assignee)

Updated

4 years ago
Attachment #8452837 - Flags: review?(choller)
Ehsan, can you quickly explain, why this is not supported yet by clang-cl? I thought, clang-cl and clang will link the same ASan runtime library, and I think all the __asan_default_options thing does is tell the ASan runtime library which default options are used. It's not some extra magic done in Clang, it's just used in compiler-rt.

Otherwise, the patch looks fine to me, if we need it :)
Flags: needinfo?(ehsan)
Comment on attachment 8452837 [details] [diff] [review]
Do not use __asan_default_options with clang-cl because it is not supported yet

Nevermind, I think I found out from the source that weak functions/attributes don't work on Windows and therefore they disabled __asan_default_options, as it's a weak function.
Attachment #8452837 - Flags: review?(choller) → review+
Flags: needinfo?(ehsan)
(Assignee)

Comment 4

4 years ago
Yeah.  Also, note that most of the compiler-rt support for ASAN on clang-cl code is code that is not shared with the Linux/OSX one.  We probably need to fix this at some point, but for now I'm more interested in getting to _a_ build. :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/756dae0c26b2
Yep, I fully agree. And as a workaround we can set these options at runtime until we have a solution.
https://hg.mozilla.org/mozilla-central/rev/756dae0c26b2
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.