1036270 - cfx ignores command line options if they are already defined in local.json

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect, P2)

Description

[uFFFD]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140605174243

Steps to reproduce:

I have a "default" configuration in local.json as follows:

{
  "configs": {
    "default": ["-b", "C:/Tools/fx/release/firefox.exe", "-p", "C:/temp/firefoxprofile"]
  }
}


and run `cfx run` with command line options `-b/--binary`, `-p/--profiledir` and `--no-run`:

(C:\Tools\fx\addon-sdk) C:\newaddon>cfx run --no-run -b C:\Tools\fx\beta\firefox.exe -p .\profile


Actual results:

Using binary at 'C:/Tools/fx/release/firefox.exe'.
Using profile at 'C:\temp\firefoxprofile'.
To launch the application, enter the following command:
C:/Tools/fx/release/firefox.exe -profile C:\temp\firefoxprofile -no-remote


Expected results:

Using binary at 'C:\Tools\fx\beta\firefox.exe'.
Using profile at 'C:\newaddon\profile'.
To launch the application, enter the following command:
C:\Tools\fx\beta\firefox.exe -profile C:\newaddon\profile -no-remote

Comment 1

[uFFFD]

The explicit options should override the implicit ones in my opinion
similar to what cURL does
http://curl.haxx.se/docs/manpage.html
> -u, --user <user:password>
> Specify the user name and password to use for server authentication. Overrides -n, --netrc and --netrc-optional.

possible fix for this:
change https://github.com/mozilla/addon-sdk/blob/master/python-lib/cuddlefish/__init__.py#L602 from
  parser_kwargs['arguments'] += config_args
to
  parser_kwargs['arguments'] = config_args + parser_kwargs['arguments']

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Sorry we won't be releasing any new versions of cfx, jpm is the replacement https://www.npmjs.com/package/jpm