1036290 - Use nsAutoTArray for copying TouchArray

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #3)
> Comment on attachment 8452191 [details] [diff] [review]
> Use mozilla::WidgetTouchEvent::TouchArray instead of
> nsTArry<nsRefPtr<mozilla::dom::Touch>>
> 
> Review of attachment 8452191 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> You could use "auto" in some of these places too.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8452966 [details] [diff] [review]
Patch

Review of attachment 8452966 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, no; I meant the C++ "auto" feature for declaring the types of local variables.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #2)
> Comment on attachment 8452966 [details] [diff] [review]
> Patch
> 
> Review of attachment 8452966 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Sorry, no; I meant the C++ "auto" feature for declaring the types of local
> variables.

Oh... But anyway, isn't it better to use nsAutoTArray in the cases of the patch?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8452966 [details] [diff] [review]
Patch

Review of attachment 8452966 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, you're right.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

(I give r- in general for code using auto. It makes code faster to write but harder to read, and
I prefer good readability.)

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I agree with Smaug. If other developers use "auto" in a lot of places, we need to check its definition of every variable. So, I think that we shouldn't use "auto" as far as possible. Although, it might be better to use in template.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/19663c22e7eb

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/19663c22e7eb