add a list of tracking/project/etc tracking flags to the bugmail filtering prefs page

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glob, Assigned: glob)

Tracking

Production
x86
macOS

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

5 years ago
as it isn't clear which flags are "tracking" vs "project" vs "b2g" etc, the bugmail filtering preference tab should list all tracking-flag fields grouped type as part of the help text.
Assignee

Comment 1

5 years ago
- adds a blurb about the grouping and the full list of fields per type
- fixes invalid html in filter examples
- removes redundant code in Bugzilla->tracking_flag_names
- removes unused tracking flag type "b2g flags"
Attachment #8453631 - Flags: review?(dkl)
Comment on attachment 8453631 [details] [diff] [review]
1036303_1.patch

Review of attachment 8453631 [details] [diff] [review]:
-----------------------------------------------------------------

[bugzilla@bugzilla-bmo 1036303]$ bz patch
fetching patches from bug 1036303
add a list of tracking/project/etc tracking flags to the bugmail filtering prefs page
  0. cancel
  1. 1036303_1.patch 
? 1
patching 1036303 with #8453631
fetching attachment #8453631 [details] [diff] [review]
Bug 1036303: 1036303_1.patch
creating 1036303-8453631.patch
patching file extensions/BugmailFilter/Extension.pm
Hunk #1 FAILED at 111.
Hunk #2 succeeded at 159 (offset 3 lines).
Hunk #3 succeeded at 218 (offset 3 lines).
Hunk #4 succeeded at 233 (offset 3 lines).
1 out of 4 hunks FAILED -- saving rejects to file extensions/BugmailFilter/Extension.pm.rej
patching file extensions/BugmailFilter/template/en/default/account/prefs/bugmail_filter.html.tmpl
patching file extensions/BugmailFilter/web/js/bugmail-filter.js
patching file extensions/TrackingFlags/Extension.pm
patching file extensions/TrackingFlags/lib/Constants.pm

r=dkl with bit-rot fixed on commit.
Attachment #8453631 - Flags: review?(dkl) → review+
Assignee

Comment 3

5 years ago
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   f7e326a..3e8a6b2  master -> master
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Thank you for this :-)
Blocks: 1041515
Assignee

Updated

5 years ago
No longer blocks: 1041515
Component: Extensions: Other → Extensions: BugmailFilter
You need to log in before you can comment on or make changes to this bug.