1036303 - add a list of tracking/project/etc tracking flags to the bugmail filtering prefs page

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[:glob ✱]

as it isn't clear which flags are "tracking" vs "project" vs "b2g" etc, the bugmail filtering preference tab should list all tracking-flag fields grouped type as part of the help text.

Comment 1

[:glob ✱]

Attachment: 1036303_1.patch

- adds a blurb about the grouping and the full list of fields per type
- fixes invalid html in filter examples
- removes redundant code in Bugzilla->tracking_flag_names
- removes unused tracking flag type "b2g flags"

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 8453631 [details] [diff] [review]
1036303_1.patch

Review of attachment 8453631 [details] [diff] [review]:
-----------------------------------------------------------------

[bugzilla@bugzilla-bmo 1036303]$ bz patch
fetching patches from bug 1036303
add a list of tracking/project/etc tracking flags to the bugmail filtering prefs page
  0. cancel
  1. 1036303_1.patch 
? 1
patching 1036303 with #8453631
fetching attachment #8453631 [details] [diff] [review]
Bug 1036303: 1036303_1.patch
creating 1036303-8453631.patch
patching file extensions/BugmailFilter/Extension.pm
Hunk #1 FAILED at 111.
Hunk #2 succeeded at 159 (offset 3 lines).
Hunk #3 succeeded at 218 (offset 3 lines).
Hunk #4 succeeded at 233 (offset 3 lines).
1 out of 4 hunks FAILED -- saving rejects to file extensions/BugmailFilter/Extension.pm.rej
patching file extensions/BugmailFilter/template/en/default/account/prefs/bugmail_filter.html.tmpl
patching file extensions/BugmailFilter/web/js/bugmail-filter.js
patching file extensions/TrackingFlags/Extension.pm
patching file extensions/TrackingFlags/lib/Constants.pm

r=dkl with bit-rot fixed on commit.

Comment 3

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   f7e326a..3e8a6b2  master -> master

Comment 4

[Ed Morley [:emorley]]

Thank you for this :-)