1036336 - [Collection App] Icons jump after rendering all of them

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Cristian Rodriguez (:crdlc)]

Attachment: Video

STR:

1) Open "Social" smart collection (or whatever)
2) See how the content is translated some pixels when all icons are rendered and the scroll detects it

Video attached to show the issue

-----

https://github.com/mozilla-b2g/gaia/blob/master/apps/collection/view.html#L79

Notice that <gaia-grid> has not height because all the content is translated with transformations. The issue disappears if I add this here https://github.com/mozilla-b2g/gaia/blob/master/apps/collection/style/css/view.css#L1

height: 1000%;

Comment 1

[Cristian Rodriguez (:crdlc)]

Vivien, should I move this to Zoom&Pan component? or any suggestion is more than welcome

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Cristian Rodriguez (:crdlc) from comment #1)
> Vivien, should I move this to Zoom&Pan component? or any suggestion is more
> than welcome

Just removing flex-direction: column on the container also seems to resolve the issue for this case. But it breaks the offline case.

Seems much more a css issue related to the usage of flex than a pan/zoom issue to me.

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Comment 4

[Cristian Rodriguez (:crdlc)]

Thanks Vivien, good catch

(In reply to Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) from comment #2)
> (In reply to Cristian Rodriguez (:crdlc) from comment #1)
> > Vivien, should I move this to Zoom&Pan component? or any suggestion is more
> > than welcome
> 
> Just removing flex-direction: column on the container also seems to resolve
> the issue for this case. But it breaks the offline case.
> 
> Seems much more a css issue related to the usage of flex than a pan/zoom
> issue to me.

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8453636 [details]
Github pull request

Things seem to keep working for me, and I'm not seeing a "jump", so looks good to me. Thanks!

Comment 6

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/crdlc/gaia/commit/8eca3ec6a54ac9d812b05355a6077a9ea80c96b6

Comment 7

[Shine(Leave from Mozilla)]

Attachment: video

This issue has been verified successfully on Flame 2.1
See attachment: Verify_1036336.MP4
Reproducing rate: 0/5

Flame 2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0