1036409 - [e10s] Inspector doesn't re-select the last selected node after page reload

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[Patrick Brosset <:pbro>]

In a non e10s tab:
- Open the inspector
- Select a node nested somewhere (not just html, head or body, something nested below that)
- Reload the page
==> Observer that the markup-view auto-expands to that node and selects it

In an e10s tab:
==> body is always reselected by default

Comment 1

[Brian Grinstead [:bgrins]]

This is controlled by selectionCssSelector and is most likely failing because of the call to _target.url in the getter http://dxr.mozilla.org/mozilla-central/source/browser/devtools/inspector/inspector-panel.js#381

Comment 2

[Brian Grinstead [:bgrins]]

Also, the call a get the CSS selector is not remote safe for the same reason that the "Copy Unique Selector" context menu isn't.  See https://bugzilla.mozilla.org/show_bug.cgi?id=967201#c4 for an explanation of how to fix this part

Comment 3

[Heather Arthur [:harth]]

Attachment: Use remote method to get unique selector

Well, that was easy after all. Uses the new remote getUniqueSelector() method.

Try:
https://tbpl.mozilla.org/?tree=Try&rev=bad28252a0bc

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8508932 [details] [diff] [review]
Use remote method to get unique selector

Review of attachment 8508932 [details] [diff] [review]:
-----------------------------------------------------------------

R+ assuming a green try build.

Comment 5

[Patrick Brosset <:pbro>]

https://hg.mozilla.org/integration/fx-team/rev/4844e9c181aa

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4844e9c181aa

Comment 7

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Reproduced the initial issue in Firefox 36 Nightly from 2014-10-21. The issue no longer reproduces in the latest Firefox 38 Nightly (BuildID=20150211222327) on Windows 7 x64, Mac OS X 10.9.5, Ubuntu 12.04 x86.