Closed
Bug 1036415
Opened 10 years ago
Closed 10 years ago
'TypeError: "AppFrames" is read-only' exception on Mulet
Categories
(Firefox OS Graveyard :: Runtime, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S6 (18july)
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
709 bytes,
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
Because Mulet loads AppFrames.jsm without reuseglobal, the global scope of AppFrames.jsm has a different behavior and prevents doing that: const AppFrames = this.AppFrames; But with reuseglobal we still want to bind Apprames to `this`, so let's do that instead: let AppFrames = this.AppFrames;
Assignee | ||
Comment 1•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=3ebc3ef60758
Attachment #8453072 -
Flags: review?(jryans)
Comment on attachment 8453072 [details] [diff] [review] patch Review of attachment 8453072 [details] [diff] [review]: ----------------------------------------------------------------- I hope someday we make all these weird global modes less confusing... :/
Attachment #8453072 -
Flags: review?(jryans) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to J. Ryan Stinnett [:jryans] from comment #2) > Comment on attachment 8453072 [details] [diff] [review] > patch > > Review of attachment 8453072 [details] [diff] [review]: > ----------------------------------------------------------------- > > I hope someday we make all these weird global modes less confusing... :/ bholley is working on figuring out why we need such global sharing hack to hopefully disable it. Otherwise I tried to ask kyle and jim about why we have this behavior and got no helful response... I still think that's a bug and we can do something less disturbing. My patch to merge the compartment of JS modules does the same kind of hack with this buggy behavior.
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/80b00f38b6fe
Flags: in-testsuite-
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/80b00f38b6fe
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
You need to log in
before you can comment on or make changes to this bug.
Description
•