1036415 - 'TypeError: "AppFrames" is read-only' exception on Mulet

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[Alexandre Poirot [:ochameau]]

Because Mulet loads AppFrames.jsm without reuseglobal, the global scope of AppFrames.jsm has a different behavior and prevents doing that:
  const AppFrames = this.AppFrames;
But with reuseglobal we still want to bind Apprames to `this`, so let's do that instead:
  let AppFrames = this.AppFrames;

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=3ebc3ef60758

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8453072 [details] [diff] [review]
patch

Review of attachment 8453072 [details] [diff] [review]:
-----------------------------------------------------------------

I hope someday we make all these weird global modes less confusing... :/

Comment 3

[Alexandre Poirot [:ochameau]]

(In reply to J. Ryan Stinnett [:jryans] from comment #2)
> Comment on attachment 8453072 [details] [diff] [review]
> patch
> 
> Review of attachment 8453072 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I hope someday we make all these weird global modes less confusing... :/

bholley is working on figuring out why we need such global sharing hack to hopefully disable it.
Otherwise I tried to ask kyle and jim about why we have this behavior and got no helful response...
I still think that's a bug and we can do something less disturbing. My patch to merge the compartment of JS modules does the same kind of hack with this buggy behavior.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/80b00f38b6fe

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/80b00f38b6fe