1036431 - Setting AudioContext.mozAudioChannelType doesn't set the channel type on mStream

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[(no longer active)]

We do that if the channel type is passed to the ctor <http://mxr.mozilla.org/mozilla-central/source/content/media/webaudio/AudioDestinationNode.cpp?force=1#300> but not when the attribute is set: <http://mxr.mozilla.org/mozilla-central/source/content/media/webaudio/AudioDestinationNode.cpp?force=1#509>.  I think that is a bug, Andrea what do you think?

Comment 1

[Andrea Marchesini [:baku]]

Attachment: stream.patch

It's a bug. What about this patch?

Comment 2

[(no longer active)]

Comment on attachment 8463340 [details] [diff] [review]
stream.patch

Review of attachment 8463340 [details] [diff] [review]:
-----------------------------------------------------------------

Can you see if you can write a test for this, please?  Thanks!

Comment 3

[Andrea Marchesini [:baku]]

> Can you see if you can write a test for this, please?  Thanks!

I don't have any idea about how to test if mStream is using the right AudioChannel. Any suggestion?

Comment 4

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/deb63ed4434b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/deb63ed4434b

Comment 6

[(no longer active)]

(In reply to comment #3)
> > Can you see if you can write a test for this, please?  Thanks!
> 
> I don't have any idea about how to test if mStream is using the right
> AudioChannel. Any suggestion?

How about adding a [ChromeOnly] testing API that returns the value?  :-)

Comment 7

[Andrea Marchesini [:baku]]

Follow up: 1046582