Closed Bug 1036431 Opened 9 years ago Closed 9 years ago

Setting AudioContext.mozAudioChannelType doesn't set the channel type on mStream

Categories

(Core :: Web Audio, defect)

Product:
Core
Component:
Web Audio
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: ehsan.akhgari, Assigned: baku)

References

Details

Attachments

(1 file)

stream.patch
1.75 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
We do that if the channel type is passed to the ctor <http://mxr.mozilla.org/mozilla-central/source/content/media/webaudio/AudioDestinationNode.cpp?force=1#300> but not when the attribute is set: <http://mxr.mozilla.org/mozilla-central/source/content/media/webaudio/AudioDestinationNode.cpp?force=1#509>.  I think that is a bug, Andrea what do you think?
Flags: needinfo?(amarchesini)
Attached patch stream.patch — — Splinter Review 
It's a bug. What about this patch?
Attachment #8463340 - Flags: review?(ehsan)
Flags: needinfo?(amarchesini)
Comment on attachment 8463340 [details] [diff] [review]
stream.patch

Review of attachment 8463340 [details] [diff] [review]:
-----------------------------------------------------------------

Can you see if you can write a test for this, please?  Thanks!
Attachment #8463340 - Flags: review?(ehsan) → review+
> Can you see if you can write a test for this, please?  Thanks!

I don't have any idea about how to test if mStream is using the right AudioChannel. Any suggestion?
https://hg.mozilla.org/mozilla-central/rev/deb63ed4434b
Assignee: nobody → amarchesini
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
(In reply to comment #3)
> > Can you see if you can write a test for this, please?  Thanks!
> 
> I don't have any idea about how to test if mStream is using the right
> AudioChannel. Any suggestion?

How about adding a [ChromeOnly] testing API that returns the value?  :-)
Follow up: 1046582
Blocks: 1046582
You need to log in before you can comment on or make changes to this bug.