1036445 - Landing Pages: unbreak the build

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Aki Rose Braun [:akirose]]

This is a more complex ticket than it looks like at first glance. JShint doesn't like that Make and Mustache are used before being defined. I'd prefer that the solution to this problem not be
    Make = Make || {},
    Mustache = Mustache || {},
because the compiled files have the correct variables in the correct places. That said, the whole point to running these scripts is to improve your uncompiled files.

Gotta figure this out.

Comment 1

[Jon Buckley [:jbuck]]

You might be able to fix this by adding those two globals to the ignore list on a per-file basis via:

/* global Make, Mustache */

I think.

Comment 3

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/webmaker-landing-pages/pull/15

Comment 4

[Aki Rose Braun [:akirose]]

Comment on attachment 8456965 [details] [review]
https://github.com/mozilla/webmaker-landing-pages/pull/15

You are my sunshine, my only sunshine!

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker-landing-pages

https://github.com/mozilla/webmaker-landing-pages/commit/23c9ce70b2a5b66ac6c234f20ee4b77916aeaa83
Fix bug 1036445 - Travis CI passes once again!